Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine define generate Help file with Docfx #236

Open
chuongmep opened this issue Mar 12, 2023 · 6 comments
Open

Combine define generate Help file with Docfx #236

chuongmep opened this issue Mar 12, 2023 · 6 comments
Labels
Documentation Additional documentation Nodes Nodal improvement

Comments

@chuongmep
Copy link

chuongmep commented Mar 12, 2023

If this is an issue for Dynamo Core, please submit your issue on the Dynamo Core issues page or if this is an issue for Dynamo for Revit, please post your issue on the Dynamo for Revit Issues page.

If this issue is not a Wishlist request, please check the Dynamo forum, and start a thread there to discuss your issue.

What improvement/feature would you like to see in Dynamo?

Example I have this document online : https://chuongmep.github.io/OpenMEP/api/OpenMEP.ConnectorManager.ConnectorManager.html
With Method defind for pictute example : https://github.com/chuongmep/OpenMEP/blob/ec4dee35ac75a515e158f65842ef9f72a2c28df8/OpenMEP/ConnectorManager/ConnectorManager.cs#LL19C5-L19C5

I don't want defind two time one for help file and one for document online, view this isssue : DynamoDS/Dynamo#13648 (comment)

How would you see this improvement/feature working?

  • User just need defind same format with docfx and then can resolve problem for both

Please provide any sketch/mock-up or video of your requested improvement/feature

Example:

    /// <summary>
    /// return connector manager of element
    /// </summary>
    /// <param name="element">element</param>
    /// <returns name="ConnectorManager">Autodesk.Revit.DB.ConnectorManager</returns>
    /// <example>
    /// ![](../OpenMEPPage/connectormanager/dyn/pic/ConnectorManager.GetConnectorManager.png)
    /// </example>

///

This will be generate same with docfx include code, picture, markdown,...

@chuongmep chuongmep changed the title Combine define Help file with Docfx Combine define generate Help file with Docfx Mar 12, 2023
@Amoursol
Copy link
Contributor

@chuongmep just to confirm, you are looking for Dynamo to also support the .docfx file format as well as the current Markdown approach? 😊

@chuongmep
Copy link
Author

@Amoursol yes, at the moment my process break with Markdown define in dynamo, it is not same and I don't have any way to connect document guideline.

@Amoursol
Copy link
Contributor

@mjkkirschner any reason why we couldn't also support the docfx format? Assuming we'll also need to add it to the HTML sanitizer workflow? So just a time-cost?

@mjkkirschner
Copy link
Member

markdown is simpler and wider adopted than docfx, docfx requires use of a library and it generates a static site on the other end, unclear if it's appropriate for our use case without investigation.

It may perform some kind of sanitization as well but I have no idea.

@chuongmep
Copy link
Author

chuongmep commented Mar 13, 2023 via email

@Amoursol
Copy link
Contributor

@chuongmep we hear you on how useful it would be and will keep it in mind when we loop back onto the Documentation piece.

Currently we use a Markdown input that goes through an HTML sanitizer to create the HTML pages in order to meet security obligations. Any further improvement would also need to meet those standards.

@Amoursol Amoursol added Nodes Nodal improvement Documentation Additional documentation labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Additional documentation Nodes Nodal improvement
Projects
Status: Backlog
Development

No branches or pull requests

3 participants