Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform execution plan state updates in workers #369

Closed
adamruzicka opened this issue Oct 12, 2020 · 1 comment
Closed

Perform execution plan state updates in workers #369

adamruzicka opened this issue Oct 12, 2020 · 1 comment

Comments

@adamruzicka
Copy link
Contributor

Execution plan state changes currently happen all over the place, this can cause issues if something hooks into the save process like foreman-tasks does. It can lead to various connection pool depletion issues
@adamruzicka adamruzicka mentioned this issue Oct 12, 2020
Open
4 tasks
@adamruzicka
Copy link
Contributor Author

We shouldn't consider hooking into the save process as supported. If needed, it can be worked around the same way as here theforeman/foreman-tasks#652 .

Once #368 gets fixed, execution plan state updates will only touch the execution plan and therefore doing this in orchestrator won't be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamruzicka