Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steps in finalize get skipped even if skipping a step in run phase fails #390

Open
adamruzicka opened this issue May 12, 2021 · 0 comments

Comments

@adamruzicka
Copy link
Contributor

adamruzicka commented May 12, 2021

class MyAction < Dynflow::Action
  def run(event = nil)
    raise "Halt"
  end

  def finalize
  end
end

Steps to reproduce:

  1. Plan the action above
  2. Once it gets stuck, go into dynflow console and try to skip the run step
  3. Click resume

Actual results:
Between steps 2 and 3, the run step turns over to skipping, the finalize step turns over to skipped. After 3, the run step goes back to error. Trying to skip it again leads to invalid transition skipped > skipped error for the finalize step.

Expected results:
Skipped steps are already ignored when skipping or finalize steps being skipped after run steps are really skipped.

Notes:
When auto rescue is enabled, it kinda does steps 2 and 3 for you behind the scenes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant