Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double counting of solid phase hydrometeors in CALIPSO and CloudSat simulator diagnostics of COSP #6735

Open
yunpengshan2014 opened this issue Nov 6, 2024 · 4 comments
Labels
Atmosphere bug v3.0 Issues affecting v3.0

Comments

@yunpengshan2014
Copy link
Contributor

yunpengshan2014 commented Nov 6, 2024

Issue Description:

PR #5891 introduced an unexpected issue affecting the COSP CALIPSO and CloudSat simulator diagnostics. This issue arises from assigning the P3 diagnostic precipitating solid phase particle falling flux to “precip_ice_flux” for diagnostic purposes. Since “precip_ice_flux” is also a required input field and is treated as snow in the CALIPSO and CloudSat simulators, this results in the double-counting of solid phase particles. This is because the E3SMv3 implemented the single-ice category version of P3 as used in SCREAM, where the simulated solid particles are either precipitating or non-precipitating.

While assigning the P3 diagnostic precipitating solid phase particle falling flux to “precip_ice_flux” is technically correct, it inadvertently leads to double-counting of ice in the CALIPSO and CloudSat simulator's cloud diagnostics. Note that this issue does not impact model simulations.

More discussion is here: https://acme-climate.atlassian.net/wiki/spaces/ATMOS/pages/edit-v2/4654497798?draftShareId=c179bae8-e00d-4754-8faf-0d05f5eb48a2

@rljacob
Copy link
Member

rljacob commented Nov 6, 2024

PR #5827 indicates it was closed without being merged. Did this code make it to master?

@yunpengshan2014 yunpengshan2014 changed the title Proposed Modifications to PR #5827 and Coupling Between P3 and COSP Double counting of solid phase hydrometeors in CALIPSO and CloudSat simulator diagnostics of COSP Nov 6, 2024
@yunpengshan2014
Copy link
Contributor Author

PR #5827 indicates it was closed without being merged. Did this code make it to master?

This code has been merged to V3.0.1. So, it should be also in master.

@crterai
Copy link
Contributor

crterai commented Nov 6, 2024

@yunpengshan2014 - I think PR #5827 is not the correct PR # and it should be #5891 Would you correct that above?

@yunpengshan2014
Copy link
Contributor Author

@yunpengshan2014 - I think PR #5827 is not the correct PR # and it should be #5891 Would you correct that above?

Yes, Chris and Rob. #5891 is the correct PR. I have correct it here and also the confluence page. Thanks for capturing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Atmosphere bug v3.0 Issues affecting v3.0
Projects
None yet
Development

No branches or pull requests

3 participants