Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing warnings.filterwarnings("ignore") if it is not needed #205

Open
1 task
tomvothecoder opened this issue Aug 7, 2023 · 0 comments
Open
1 task
Labels
question Further information is requested

Comments

@tomvothecoder
Copy link
Collaborator

tomvothecoder commented Aug 7, 2023

In this PR, we replace np.filterwarnings.warnings("ignore") with filterwarnings.warnings("ignore") because numpy deprecated their wrapper for filterwarnings.

We should check the following:

  1. Figure out why np.filterwarnings.warnings("ignore") was originally implemented
    • For example, was it used to filter out warnings such as divide by zero. If so, why would we want to filter these warnings?
  2. Check if filterwarnings.warnings("ignore") is still needed -- it might be filtering out all warnings and not just numpy warnings
    • Remove this line and do a test run
      • If no warnings are produced, remove this line
      • If warnings are produced, note the exact packages and modules. Determine if we need to ignore specific warnings or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Development

No branches or pull requests

1 participant