Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly close xr.Dataset in VarHandler.cmorize() #244

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

tomvothecoder
Copy link
Collaborator

@tomvothecoder tomvothecoder commented Feb 22, 2024

Description

By explicitly closing the multi-file xr.Dataset object, we avoid any possibility of resource locking with .nc files

This is an attempted fix for E3SM-Project/zppy#549.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

- This is to avoid any possibility of resource locking with `.nc` files
@tomvothecoder tomvothecoder added the bug Something isn't working label Feb 22, 2024
@tomvothecoder tomvothecoder self-assigned this Feb 22, 2024
@tomvothecoder tomvothecoder merged commit 21ecaef into master Feb 22, 2024
3 checks passed
@tomvothecoder tomvothecoder deleted the bug/549-zppy-ts branch February 22, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant