From 0da5fdf4a609bfcbfd5ff16d306034ee6021f43f Mon Sep 17 00:00:00 2001 From: forsyth2 <30700190+forsyth2@users.noreply.github.com> Date: Fri, 17 Jan 2025 09:42:23 -0800 Subject: [PATCH] Further PR template updates (#662) --- .github/pull_request_template.md | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 111503fb..8a0a62f8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,12 @@ -## Issue resolution +## Summary + +Objectives: +- Objective 1 +- Objective 2 +- ... +- Objective n + +Issue resolution: - Closes # Select one: This pull request is... @@ -7,11 +15,13 @@ Select one: This pull request is... - [ ] a new feature: increment the minor version - [ ] an incompatible (non-backwards compatible) API change: increment the major version -Please fill out either the "Small Change" or "Big Change" section, and delete the other. +Please fill out either the "Small Change" or "Big Change" section (the latter includes the numbered subsections), and delete the other. ## Small Change - [ ] To merge, I will use "Squash and merge". That is, this change should be a single commit. +- [ ] Logic: I have visually inspected the entire pull request myself. +- [ ] Pre-commit checks: All the pre-commits checks have passed. ## Big Change @@ -19,12 +29,6 @@ Please fill out either the "Small Change" or "Big Change" section, and delete th ### 1. Does this do what we want it to do? -Objectives: -- Objective 1 -- Objective 2 -- ... -- Objective n - Required: - [ ] Product Management: I have confirmed with the stakeholders that the objectives above are correct and complete. - [ ] Testing: I have added or modified at least one "min-case" configuration file to test this change. Every objective above is represented in at least one cfg.