Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variant count field should be an integer and enforced as such by the validation #84

Open
jdhayhurst opened this issue Jun 18, 2021 · 1 comment
Open

Variant count field should be an integer and enforced as such by the validation #84

jdhayhurst opened this issue Jun 18, 2021 · 1 comment

Comments

@jdhayhurst
Copy link
Contributor

currently '123 ' is permitted and interpreted as a string rather than an int, which causes problems down the line upon import. We could handle 'NR' with a nonsensical numerical code e.g. -1. This numerical code will need to be displayed correctly as 'NR' on the search UI which requires some logic to be added somewhere between validation and the search UI.
@jdhayhurst
Copy link
Contributor Author

not sure if this is still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdhayhurst