Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPHENO status #615

Closed
bschilder opened this issue Feb 2, 2024 · 5 comments
Closed

UPHENO status #615

bschilder opened this issue Feb 2, 2024 · 5 comments

Comments

@bschilder
Copy link

Is your feature request related to a problem? Please describe.
I was wondering what the current status and plans were for the UPHENO ontology. It doesn't seem to be currently accessible via OLS (in the browser or the rols R package which uses the API).
I noticed some old issues and PRs that removed it, but I'm not sure why:

I also noticed that mappings to UPHENO terms do still exist in relation to other ontologies (e.g. DOID):
https://www.ebi.ac.uk/ols4/ontologies/doid/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FUPHENO_0001001

Both v1 and v2 or UPHENO are available via the OBO Foundry
https://obofoundry.org/ontology/upheno.html
As well as on GitHub:
https://github.com/obophenotype/upheno/

Describe the solution you'd like
Have UPHENO be available via OLS.

Describe alternatives you've considered
Currently, I'm downloading UPHENO directly from their OBO Foundry ("https://purl.obolibrary.org/obo/upheno/v2/upheno.owl") and importing it into R with simona::import_ontology

Additional context
I'm asking in part as it relates to a new package I'm making to help use, filter, and manipulate ontologies and knowledge graphs in R:
https://github.com/neurogenomics/KGExplorer

Thanks for your help!,
Brian

@haideriqbal
Copy link
Collaborator

Thank you for your inquiry about the inclusion of UPHENO ontology in the OLS. UPHENO is managed by OBO (Open Biological and Biomedical Ontology) Foundry and we're glad to inform you that UPHENO is in the process of being recognized by the OBO Foundry community. It's the efforts of the OBO community that determine the inclusion of new ontologies into the OBO.

Once UPHENO is formally part of the OBO, it will automatically be integrated into OLS and then you can query it via OLS.

@matentzn
Copy link
Contributor

matentzn commented Feb 2, 2024

Just to be clear: there is a slightly confusing situation as there is a "upheno (1)" that has already been accepted in OBO, and a new one developed by @jamesamcl and his team which you can see, for now, here: https://ols.monarchinitiative.org/ontologies/upheno2

It is odd that upheno1 is not at all in OLS (it should be), but its probably because it has 40K unsatisfiable classes..

@bschilder
Copy link
Author

Thanks so much for the info @matentzn @haideriqbal !

Just to be clear: there is a slightly confusing situation as there is a "upheno (1)" that has already been accepted in OBO, and a new one developed by @jamesamcl and his team which you can see, for now, here: https://ols.monarchinitiative.org/ontologies/upheno2

Thanks for the link! I'm guessing this page is still under development though? based on the fact that the ontology isn't actually available for download (at least not that I can find there):
https://ols.monarchinitiative.org/ontologies/upheno2/download

It is odd that upheno1 is not at all in OLS (it should be), but its probably because it has 40K unsatisfiable classes..

This seemed strange to me as well since upheno1 has been out for a quite a while. @haideriqbal am I mistaken in thinking that if it's on OBO Foundry already (see here) it should also be available on OLS? Is the issue due to the errors reported here? Not sure is this is the same issue with 40k 40K unsatisfiable classes that @matentzn mentioned.

@haideriqbal
Copy link
Collaborator

Hi @bschilder after further investigating the issue on our end we've come to know that there is an issue with one of the imports of UPHENO ontology. The import is not in the correct format and hence is not loaded in OLS. I've opened an issue with the UPHENO team as well. You can have a look here obophenotype/upheno#929.

Once the UPHENO team fixes the issue with the import then the UPHENO ontology would automatically load in the OLS.

@haideriqbal haideriqbal reopened this Feb 5, 2024
@bschilder
Copy link
Author

@haideriqbal thanks so much for looking into this! Glad to hear there's activity on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants