From 17479897ec3b7c7506345422418d3ee1f54ca0ea Mon Sep 17 00:00:00 2001 From: tcezard Date: Wed, 11 Oct 2023 14:52:25 +0100 Subject: [PATCH] run_container does not retrun anything --- cli/docker_validator.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cli/docker_validator.py b/cli/docker_validator.py index 8d3e396..e6d5133 100644 --- a/cli/docker_validator.py +++ b/cli/docker_validator.py @@ -226,13 +226,12 @@ def download_container_image(self): logger.info(f"Pulling container ({container_image}) image") try: run_command_with_output("pull container image", f"{self.docker_path} pull {container_image}:{container_tag}") - # Give the pull command some time to complete - time.sleep(5) - if not self.run_container(): - raise RuntimeError(f"Container ({self.container_name}) could not be started") except subprocess.CalledProcessError as ex: logger.error(ex) raise RuntimeError(f"Cannot pull container ({container_image}) image") + # Give the pull command some time to complete + time.sleep(5) + self.run_container() def verify_docker_env(self): self.verify_docker_is_installed()