Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking for errors in the file rename step #78

Open
adammoody opened this issue Aug 20, 2020 · 3 comments
Open

Checking for errors in the file rename step #78

adammoody opened this issue Aug 20, 2020 · 3 comments

Comments

@adammoody
Copy link
Contributor

adammoody commented Aug 20, 2020

AXL_Test is only meant to tell the caller whether calling AXL_Wait will block or not. The caller must always call AXL_Wait whether they have called AXL_Test or not. We don't want AXL_Test to do any "complete" work, it should only check and report status. Thus, we don't want to rename files here:

AXL/src/axl.c

Line 789 in d738fb7

axl_rename_files_to_final_names(id);

Also, we should consider a failed rename call to be a failed transfer. We should detect and report errors there, since it could mean that the temporary file never actually changed to the final file name:

AXL/src/axl.c

Line 723 in d738fb7

rename(dst, newdst);

We might also want to consider a transfer to have failed if we fail to copy the metadata:

axl_meta_apply(dst_file, meta);

@adammoody
Copy link
Contributor Author

Fixing this in 1ac255a

@adammoody
Copy link
Contributor Author

Resolved with #80

@adammoody adammoody reopened this Aug 29, 2020
@adammoody
Copy link
Contributor Author

Oh, wait. The metadata issue is still unresolved. Will keep this open until that's also addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant