From 6b1e735f49fc16940e92811d1378d42d79291154 Mon Sep 17 00:00:00 2001
From: Axel Huebl <axel.huebl@plasma.ninja>
Date: Mon, 2 Sep 2024 16:09:49 -0700
Subject: [PATCH] HDF5 1.14.3: Skip `amrex.fpe_trap_invalid`

---
 .azure-pipelines.yml    | 6 +++++-
 CMakeLists.txt          | 8 ++++++++
 Examples/CMakeLists.txt | 6 +-----
 3 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
index b11e9a1318f..70cf0a16d95 100644
--- a/.azure-pipelines.yml
+++ b/.azure-pipelines.yml
@@ -10,7 +10,11 @@ pr:
 jobs:
 - job:
   variables:
-    AMREX_CMAKE_FLAGS: -DAMReX_ASSERTIONS=ON -DAMReX_TESTING=ON -DpyAMReX_IPO=OFF
+    # TODO: fpe_trap_invalid broken in HDF5 1.14.3
+    #       Remove "-DWarpX_TEST_FPETRAP_ARGS=..." once 1.14.4 is available.
+    #       https://github.com/HDFGroup/hdf5/issues/4801
+    #       https://github.com/conda-forge/hdf5-feedstock/pull/231
+    AMREX_CMAKE_FLAGS: -DAMReX_ASSERTIONS=ON -DAMReX_TESTING=ON -DpyAMReX_IPO=OFF -DWarpX_TEST_FPETRAP_ARGS=amrex.fpe_trap_overflow=1 amrex.fpe_trap_zero=1"
     CMAKE_BUILD_PARALLEL_LEVEL: 2
     CMAKE_GENERATOR: Ninja
     CXXFLAGS: -Wno-array-bounds  # many false positives in g++ 12
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 3b4e9199f53..b846e92fc61 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -88,7 +88,15 @@ mark_as_advanced(WarpX_TEST_CLEANUP)
 
 # Advanced option to run CI tests with FPE-trapping runtime parameters
 option(WarpX_TEST_FPETRAP "Run CI tests with FPE-trapping runtime parameters" OFF)
+set(WarpX_TEST_FPETRAP_ARGS
+    "amrex.fpe_trap_invalid = 1"
+    "amrex.fpe_trap_overflow = 1"
+    "amrex.fpe_trap_zero = 1"
+    CACHE STRING
+    "AMReX FPE-trapping runtime options if(WarpX_TEST_FPETRAP)"
+)
 mark_as_advanced(WarpX_TEST_FPETRAP)
+mark_as_advanced(WarpX_TEST_FPETRAP_ARGS)
 
 set(WarpX_DIMS_VALUES 1 2 3 RZ)
 set(WarpX_DIMS 3 CACHE STRING "Simulation dimensionality <1;2;3;RZ>")
diff --git a/Examples/CMakeLists.txt b/Examples/CMakeLists.txt
index 7ebb1465be4..65bfaae1c05 100644
--- a/Examples/CMakeLists.txt
+++ b/Examples/CMakeLists.txt
@@ -137,11 +137,7 @@ function(add_warpx_test
         )
         set(runtime_params_fpetrap "")
         if(WarpX_TEST_FPETRAP)
-            set(runtime_params_fpetrap
-                "amrex.fpe_trap_invalid = 1"
-                "amrex.fpe_trap_overflow = 1"
-                "amrex.fpe_trap_zero = 1"
-            )
+            set(runtime_params_fpetrap ${WarpX_TEST_FPETRAP_ARGS})
         endif()
         add_test(
             NAME ${name}.run