Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new FssBodySignals event #2227

Closed
Tkael opened this issue Aug 1, 2021 · 2 comments
Closed

Add new FssBodySignals event #2227

Tkael opened this issue Aug 1, 2021 · 2 comments
Assignees
Labels
9. enhancement The behaviour is as specified, but we would like to modify or extend the spec.

Comments

@Tkael
Copy link
Member

Tkael commented Aug 1, 2021

What happens now

Information on planet surface signals is only available after mapping a body

What I'd like to happen

Information on planet surface signals from an FSS scan. Don't repeat the same already-discovered signals when mapping a body.

How it can happen

A new "FssBodySignals" event has been added with info on types of signals found on a planet (biological & geological signals only).

EDDI Version

4.0.1-b2

@Tkael Tkael added the 9. enhancement The behaviour is as specified, but we would like to modify or extend the spec. label Aug 1, 2021
@Tkael
Copy link
Member Author

Tkael commented Aug 1, 2021

This could be helpful for #2212.

@Tkael
Copy link
Member Author

Tkael commented Aug 11, 2021

New FSSBodySignals event (written after an FSS scan) - includes biological and geological signals only

{ "timestamp":"2021-07-30T21:53:10Z", "event":"FSSBodySignals", "BodyName":"HIP 65165 B 6", "BodyID":10, "SystemAddress":1625385093475, "Signals":[ { "Type":"$SAA_SignalType_Biological;", "Type_Localised":"Biological", "Count":1 }, { "Type":"$SAA_SignalType_Geological;", "Type_Localised":"Geological", "Count":2 } ] }

Old SAASignalsFound event (written after mapping) - includes nonbiological signals

{ "timestamp":"2021-07-30T22:08:15Z", "event":"SAASignalsFound", "BodyName":"HIP 65165 B 6", "SystemAddress":1625385093475, "BodyID":10, "Signals":[ { "Type":"$SAA_SignalType_Biological;", "Type_Localised":"Biological", "Count":1 }, { "Type":"$SAA_SignalType_Geological;", "Type_Localised":"Geological", "Count":2 }, { "Type":"$SAA_SignalType_Human;", "Type_Localised":"Human", "Count":4 } ] }

@Tkael Tkael added this to the 4.0.2 milestone Nov 21, 2022
@Tkael Tkael self-assigned this Nov 25, 2022
@Tkael Tkael closed this as completed in 95f9082 Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9. enhancement The behaviour is as specified, but we would like to modify or extend the spec.
Projects
None yet
Development

No branches or pull requests

1 participant