Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.9.1 Installer not setting link handling for Frontier Auth #2046

Closed
Harry3528 opened this issue Aug 3, 2023 · 4 comments · Fixed by #2049
Closed

5.9.1 Installer not setting link handling for Frontier Auth #2046

Harry3528 opened this issue Aug 3, 2023 · 4 comments · Fixed by #2049
Assignees
Labels
bug FDev API Installer Related to the Windows installer
Milestone

Comments

@Harry3528
Copy link

Harry3528 commented Aug 3, 2023

Please check the Known Issues in case this has already been reported.

Please also check if the issue is covered in our Troubleshooting Guide. It might be something with a known work around, or where a third party (such as EDSM) is causing logging that is harmless.

Please complete the following information:

  • Version: [e.g. 4.0.6 - See 'Help > About E:D Market Connector'. If running from source using git then please paste the output of git log --decorate=full | head -1]
  • Game Version: [e.g. 'Live' or 'Odyssey']
  • OS: [e.g. Windows 10, Linux Debian 10.6, etc.]
  • OS Locale: [e.g. English, French, Serbian...]
  • If applicable: Browser [e.g. chrome, safari]
  • Please attach BOTH log files, by dragging and dropping them into this input:
    1. %TEMP%\EDMarketConnector.log from immediately after the bug occurs (re-running the application overwrites this file).
    2. %TEMP%\EDMarketConnector\EDMarketConnector-debug.log. See Debug Log File. NB: If you don't have this log file then you're not running the latest version of the application and should update first to see if we already fixed the bug you're reporting.

Describe the bug
The installer does not set handling of the frontier auth link to connect to the program. In chrome, i get the console error message "Failed to launch 'edmc://auth?code=[REMOVED FOR PRIVACY]&state=[REMOVED FOR PRIVACY]' because the scheme does not have a registered handler." after clicking log in on the frontier web page.

Installing 5.9.0 fixes it, and I can log in and authorize.

To Reproduce
Fresh install 5.9.1

Expected behavior
Send auth data to the program after I log in and authenticate.

Additional info: This was my first time installing the program, so people just updating will probably not encounter this issue.

@Harry3528 Harry3528 added bug unconfirmed An unconfirmed bug labels Aug 3, 2023
@Rixxan Rixxan added FDev API Installer Related to the Windows installer and removed unconfirmed An unconfirmed bug labels Aug 3, 2023
@Rixxan Rixxan self-assigned this Aug 3, 2023
@Rixxan
Copy link
Contributor

Rixxan commented Aug 3, 2023

I think I see the problem. Need to update the installer to handle some of the registry keys. Will fix in the next version!

@Rixxan Rixxan added this to the 5.9.2 milestone Aug 3, 2023
Rixxan added a commit to Rixxan/EDMarketConnector that referenced this issue Aug 3, 2023
@Rixxan Rixxan linked a pull request Aug 3, 2023 that will close this issue
@Rixxan Rixxan closed this as completed Aug 3, 2023
@Razwerkz
Copy link

Razwerkz commented Aug 4, 2023

I'm still having an issue similar to this post-update. When attempting to login, the "login" button does not seem to do anything.

@Rixxan
Copy link
Contributor

Rixxan commented Aug 4, 2023

Hmm, unfortunately, that part of the tool seem to need a little more TLC (even from before the 5.9.0 update)

Take a look at these steps and see if one of those solves it? If not let me know and we can go from there.

https://github.com/EDCD/EDMarketConnector/wiki/Troubleshooting#problems-with-frontier-authentication

@Razwerkz

@Razwerkz
Copy link

Razwerkz commented Aug 4, 2023

I was able to use the localserver-auth.bat file and authenticate. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug FDev API Installer Related to the Windows installer
Projects
None yet
3 participants