Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Station name not shown in UI before change in station provider #2077

Closed
der-eismann opened this issue Sep 18, 2023 · 2 comments
Closed

Station name not shown in UI before change in station provider #2077

der-eismann opened this issue Sep 18, 2023 · 2 comments
Assignees
Labels
bug Plugins Anything related to plugins python Pull requests that update Python code Staged Feature Complete and in Testing for Next Release
Milestone

Comments

@der-eismann
Copy link
Contributor

der-eismann commented Sep 18, 2023

Please check the Known Issues in case this has already been reported.

Please also check if the issue is covered in our Troubleshooting Guide. It might be something with a known work around, or where a third party (such as EDSM) is causing logging that is harmless.

Please complete the following information:

  • Version: 5.9.5
  • Game Version: 'Odyssey'
  • OS: Fedora 38
  • OS Locale: German
  • Please attach BOTH log files, by dragging and dropping them into this input: Actually I can't find any of the log files, need to work on that as well.

EDMarketConnector-debug.log

Describe the bug
I tried to finally update the Flatpak version of EDMC from 5.8.1 to 5.9.5, but when testing it, it seems to not be able to read the currently docked station from the journal anymore.
This is while being docked at a station. Leaving and re-docking also doesn't help. When I go back to 5.8.1 it works fine again.

I updated the Flatpak version from 5.8.1 to 5.9.5, but when testing it, it seems to not be able to read the currently docked station from the journal anymore. While debugging, I found that in my config I still had the line

station_provider = eddb

Interestingly removing the line also didn't fix the issue. Only when I enter the configuration menu and select Inara as the station provider and confirm the change, the station is shown in the UI again. Changing it back to EDSM afterwards also works fine. But it seems that the selection of the default provider is failing somehow.

To Reproduce

  1. Remove line with station_provider from EDMarketConnector.ini
  2. Start EDMC
  3. See no Station name in UI
  4. Enter configuration menu, set station provider to Inara
  5. Station name is now visible

Expected behavior
Station name shown in UI

Screenshots
Bildschirmfoto vom 2023-09-18 22-08-30

@der-eismann
Copy link
Contributor Author

This seems to be a configuration issue. I noticed that I still had EDDB set as the station_provider. But removing the line from the config doesn't help. Only when I change the station provider at least once in the settings, the station name is shown.

@der-eismann der-eismann changed the title StationName not shown in UI Station name not shown in UI before change in station provider Sep 18, 2023
@Rixxan Rixxan self-assigned this Dec 21, 2023
@Rixxan Rixxan modified the milestones: Pre-6.0 Changes, 5.10.1 Dec 21, 2023
@Rixxan
Copy link
Contributor

Rixxan commented Feb 8, 2024

I am now able to recreate the issue, and I have designed a fix that would automatically reset the provider to default on opening the preferences... but I can't seem to find how it is loaded in the first place. Ideally, if station_provider is not in the list of valid station providers, it should reset or at least throw an error.

@Rixxan Rixxan added Plugins Anything related to plugins python Pull requests that update Python code and removed unconfirmed An unconfirmed bug labels Feb 8, 2024
Rixxan added a commit to HullSeals/EDMarketConnector that referenced this issue Feb 8, 2024
Ensure we have valid providers set, and throw a warning dialog if we don't.
C1701D added a commit that referenced this issue Feb 8, 2024
@C1701D C1701D added the Staged Feature Complete and in Testing for Next Release label Feb 8, 2024
@Rixxan Rixxan modified the milestones: 5.10.x, 5.11.0 Mar 4, 2024
Rixxan pushed a commit to HullSeals/EDMarketConnector that referenced this issue Mar 14, 2024
@Rixxan Rixxan closed this as completed Mar 28, 2024
@github-project-automation github-project-automation bot moved this to Closed (Fixed) in Bug Triage Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Plugins Anything related to plugins python Pull requests that update Python code Staged Feature Complete and in Testing for Next Release
Projects
Status: Closed (Fixed)
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants