Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First authentication attempt just looping #2306

Closed
Just-Reporting opened this issue Sep 30, 2024 · 4 comments
Closed

First authentication attempt just looping #2306

Just-Reporting opened this issue Sep 30, 2024 · 4 comments
Assignees
Milestone

Comments

@Just-Reporting
Copy link

Just-Reporting commented Sep 30, 2024

System info

  • Version: 5.12.0+cc6e200
  • Game Version: Live
  • OS: Windows 10
  • OS Locale: English
  • Browser: Firefox, Edge and Brave

Bug
Trying to authenticate EDMC for the first time with Frontier.
EDMC opens an auth window in the default browser.
Login with username and password.
Browser gives a popup checking it's OK to allow the EDMC link to be opened by EDMC application.
Allow it.
Nothing happens.
Check the log file and:
_2024-09-30 07:26:39.696 UTC - INFO - 29904:36436:36436 journal_lock.JournalLock.obtain_lock:109: Exception: Couldn't lock journal directory "C:\Users\strin\Saved Games\Frontier Developments\Elite Dangerous", assuming another process running: PermissionError(13, 'Permission denied')
2024-09-30 07:26:39.706 UTC - INFO - 29904:36436:36436 EDMarketConnector.main:344: An EDMarketConnector.exe process was already running, exiting.

No popup appears - UI just does nothing.

Closing EDMC application and reclicking on the browser button to open EMDC, does cause it to reopen - but EDMC then immediately opens a new auth request tab in the browser, and repeats the above.
In the logs there's a corresponding entry:
2024-09-30 07:24:43.091 UTC - DEBUG - 51304:35312:35312 companion.Session.login:720: We do NOT have an access_token
even though that (presumably successful, as it opened the application) callback should have included the token?

Tried repeatedly with all combinations of:
Browser: Edge, Brave, Firefox
--suppress-dupe-process-popup start up param included/not included
Username/Password and Steam Authentication
Closing EDMC after initial attempt, or leaving it running and just spamming the button in the Auth browser tab
Fully logged in to the game, sat at main menu prompt, or logged out.

Exactly the same results with every attempt.

The UI shows the correct CMDR name, ship name and System, but is "Awaiting full CMDR login", regardless of whether I am fully logged in to the game and playing, sat at main menu prompt, or logged out.

Logs

EDMarketConnector.log
EDMarketConnector-debug.log

@Just-Reporting Just-Reporting added bug unconfirmed An unconfirmed bug labels Sep 30, 2024
@Rixxan
Copy link
Contributor

Rixxan commented Sep 30, 2024

Potential root cause identified, working on full fix. Tracking in #2303

@Rixxan Rixxan self-assigned this Oct 1, 2024
@Rixxan Rixxan added awaiting feedback and removed unconfirmed An unconfirmed bug labels Oct 1, 2024
@Rixxan Rixxan added this to Bug Triage Oct 1, 2024
@Rixxan Rixxan added this to the 5.13 milestone Oct 1, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in Bug Triage Oct 1, 2024
@Rixxan Rixxan moved this from Needs triage to High priority in Bug Triage Oct 1, 2024
@Rixxan
Copy link
Contributor

Rixxan commented Oct 1, 2024

I believe this issue to be resolved.

Testing a fix in the Beta track right now. Please feel free to test and let me know if the issue persists!

https://github.com/EDCD/EDMarketConnector/releases/tag/Release%2F5.12.1-rc2

@Rixxan
Copy link
Contributor

Rixxan commented Oct 3, 2024

@Rixxan Rixxan closed this as completed Oct 3, 2024
@github-project-automation github-project-automation bot moved this from High priority to Closed (Fixed) in Bug Triage Oct 3, 2024
@Just-Reporting
Copy link
Author

Can confirm that this is working perfectly in the 5.12.1 release - thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed (Fixed)
Development

No branches or pull requests

2 participants