Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RULES.md to describe actual format #157

Open
foxcpp opened this issue Dec 18, 2019 · 1 comment
Open

Update RULES.md to describe actual format #157

foxcpp opened this issue Dec 18, 2019 · 1 comment
Labels

Comments

@foxcpp
Copy link

foxcpp commented Dec 18, 2019

I am working on implementing the STARTTLS Everywhere list support in chasquid MTA.

I expected RULES.md to be up-to-date, but noticed a couple of issues with it:

  • Example file is not valid JSON (there are extra trailing commas all around).
  • It says the timestamp format is yyyy-MM-dd'T'HH:mm:ssZZZZ, but the actual value in policies.json includes the sub-second fraction.
  • It says it is possible to have Unix timestamps in timestamp fields but that does not seem to be used in practice. This introduces additional complexity in handling, however. It might be worth removing this point.
@sydneyli sydneyli added the bug label Jan 6, 2020
@sydneyli
Copy link
Contributor

sydneyli commented Jan 6, 2020

Thanks for the report, @foxcpp! RULES.md has gotten out-of-date, and we need to lint the JSON file for trailing commas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants