-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure PR preview deletion is working correctly in all cases #696
Comments
So looking at https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication:
|
So maybe we have to use a similar logic as what we do for deploying the PR, with the deploy workflow that is triggered when the build pull request has been completed: documentation/.github/workflows/deploy_pr_preview.yml Lines 10 to 14 in 4a9a15b
|
As documented in #692, the PR preview deletion worked well when removing a label set on a PR created in a feature branch of this repo: PR #664 with https://github.com/EGI-Federation/documentation/actions/runs/12688246198/job/35364361677, but failed when a PR created in a branch from a fork was merged: PR $685 with https://github.com/EGI-Federation/documentation/actions/runs/12688986914/job/35366700297
Apparently the exact same workflow was used, but looking at the actions, the permissions where not the same (cf captures at #692 (comment)):
vs
The text was updated successfully, but these errors were encountered: