-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback Course 6 - Infrastructure #72
Comments
@lhjohn apologies for the delay here - let me address each piece of feedback here so we can decide how to modify the course:
This refers to the CDM schema and results schema. Creating schemas is a well-understood topic in the DB management world and I feel like this should be prerequisite knowledge. Perhaps having a reference to something like https://www.postgresqltutorial.com/postgresql-create-schema/ would be helpful to address this feedback?
The SQL to create such schemas is going to depend on the target CDM database platform. That said, https://github.com/OHDSI/WebAPI/wiki/PostgreSQL-Installation-Guide covers this in deetail for PG. In terms of providing a SQL account with read-only access to a schema, again I'd say this is prerequisite knowledge. Perhaps a link to something like: https://tableplus.com/blog/2018/04/postgresql-how-to-create-read-only-user.html would work?
WebAPI's configuration is flexible and supports really any naming convention as described on the wiki: https://github.com/OHDSI/WebAPI/wiki/CDM-Configuration. There are some practical limits around this since schema names have a character limit along with the character limit provided in the WebAPI DB (255 characters)
Agreed - here is a nice step-by-step that we could add: https://www.thewindowsclub.com/show-file-extensions-in-windows. I forget sometimes that not everyone uses Windows :-)
Agreed - this was understandably frustrating for course attendees. Here are some steps:
I'm unclear what is meant by this - presumably this is related to DB rights to the CDM. If so, I'd suggest people understand that there is a prerequsite that they understand how rights/permissions/security is handled for their DBMS. We're not doing anything unique here but perhaps it is still very unclear of the permissions? @lhjohn if you have any further details to share on the rights/permission feedback in particular, I'd appreciate it. I want to make sure that the details are clear for people but also don't want to re-create content for well-understood DB practices. |
I have just summarised the given feedback a bit, so I am not quite sure that was meant by rights/permissions/security. I think your approach with not going into detail about all database aspects is fine. Maybe we just mention more clearly in the course prerequisites that a good understanding of database management is required. Maybe it makes sense to add a FAQ in the course resources or as a pinned post in the forum. I would actually add the MIME type explanation in a short 1 minute video, which I can edit in. I think on this there was by far the most feedback. |
@anthonysena Have you decided, which modifications you would like to make for the course? Can you implement them in the staging environment? |
Original feedback: Infrastructure Feedback.zip
Course content (target audience and material):
The text was updated successfully, but these errors were encountered: