Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Dynamic settings for module #5

Closed
ELynx opened this issue Aug 23, 2016 · 7 comments
Closed

Dynamic settings for module #5

ELynx opened this issue Aug 23, 2016 · 7 comments

Comments

@ELynx
Copy link
Owner

ELynx commented Aug 23, 2016

Use FileObserver singleton
Code-side - apply settings without polling
User-side - allow settings to take effect without restarting PoGo
See #3 for initial discussion

@krokofant
Copy link

Should the settings be used to store the different Ruby scripts? If not - how would that be solved?

@ELynx
Copy link
Owner Author

ELynx commented Aug 30, 2016

I think this can be done as simple "scripts on" list, as it works now in non-ruby version.
During UI load, list all available scripts, and let user check ones that should be actually used.
And then during XPosed module load read list of activated scripts, read script content, and load them.

On next step may be store script settings, if any, but I am not sure how a script may tell Java that it has a setting and so on.
So far even making JRuby print Hello world is a task in itself...

@griest024
Copy link
Collaborator

So it sounds like what we needs is a list of hacks that are to be implemented and then write a script for each one.

@ELynx did you get the ruby test script to run at all?

@ELynx
Copy link
Owner Author

ELynx commented Aug 30, 2016

@griest024 So far I am stuck in configuring Ruboto<->JRuby, but I am slowly going, from total exceptions to at least ones I can sort of understand. Progress is slow, tho.
I think for initial switch to Ruby only already existing hacks should be made. IVs and Lure time are pretty simple, since they are independent of any global states, are server->client only, and so on.
csv hack will be a good starting point for defining what is needed beside basics, since it requires a file write, a toast notif, and so on.

@griest024
Copy link
Collaborator

@ELynx where can we keep a dialog going? I don't want to pollute these issues with off topic discussion. Do you want to get a Discord channel going?

@ELynx
Copy link
Owner Author

ELynx commented Aug 31, 2016

@griest024 I opened a new issue #11 with latest struggles with JRuby and Ruboto. Looks like ice is broken, finally. Now we just need to place test rb file so that it is placed properly in android.
why not telegram? it is more generic.

@ELynx
Copy link
Owner Author

ELynx commented Sep 3, 2016

Implemented!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants