Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect country of visitor and load default language #53

Open
kesar opened this issue Jun 21, 2018 · 2 comments
Open

Detect country of visitor and load default language #53

kesar opened this issue Jun 21, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@kesar
Copy link
Member

kesar commented Jun 21, 2018

Detect country of visitor and load default language if exists in the list.

@kesar kesar added the enhancement New feature or request label Jun 22, 2018
@tianyangj
Copy link
Collaborator

If we need to do IP detection, we probably need an API endpoint with IP to location capability, maybe there are some free 3rd party API available to do this.

However, I feel like using client browser preferred language is probably good enough in our case. We currently doing that in app.components, maybe just need to switch to use TranslateService.getBrowserLang, https://github.com/ngx-translate/core/blob/master/projects/ngx-translate/core/src/lib/translate.service.ts#L487.

@kesar
Copy link
Member Author

kesar commented Aug 3, 2018

good point 👍 we can use browser

@tianyangj tianyangj self-assigned this Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants