-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review of the adaptive algorithm for data visualization (enhancement) #198
Comments
After internal discussion, we would like to improve the algorithm in order to show all the measurements (i.e. no subsetting) for temporal/area selections minor than a threshold (to be defined). For time/area selection greater than this threshold, the subsetting algorithm should always include the maximum and minimum measurements. |
Ok, i rechecked the subsampling step, the following is done:
Where relative area is 1.0 when no area selection is done and between 0 and 1.0 depending on the size of area selection. Meaning that right now to get the full resolution data you need to select a small area. After doing some tests i think if we set the min_step to 0 and keep the 20s as base we should get the desired effect, which is keeping the number of points/measurements around ~4k and to make sure the original data "resolution" is taken for up to 30 minutes time selection. 30 minutes would result in 1*(0+0.0208*20) = 0.41 step, resulting in full data for 1Hz as well as 2Hz (~1800 points 1Hz).
This change could be done quickly and be also deployed to production. For the second point of keeping the max/min values is after some thought not as straight forward as i expected and we would need to discuss and explore some options, i created another thicket for that purpose (#230) |
According to the formula described above, the solution based on min_step = 0 is good for time selections up to 1 day (i.e. the step size is lower than the case of min_step = 7). However, for selections above 1 day, the step size is greater than the one obtained with min_step = 7, e.g., with reference to the same case described above (relative_area =1), for 15 days we have:
So, our proposal is to set min_step = 0 for time selections up to 1 day and min_step = 7 for time selections above 1 day. Do you think it is feasible? |
It is a trivial change. For
and for
to lower the slope of the step increase. |
The proposed solution has been deployed to staging and is behaving as expected: |
We have tested the new solution on staging and is behaving as expected. Please, transfer it into the operational server. |
Moved to operations, closing ticket, feel free to comment for any related things. |
One of the feedback received at the training session in Banff was on the measurements sub-setting in the scatter plots. It seems that for products with a reduced amount of data (e.g. EEF, but also FAC products which have many "nan" values) this sub-setting is still applied in the visualization process.
For this reason, we would like to understand if it is possible to improve the adaptive algorithm for data visualization in order to:
The description reported in the FAQ (see question 6) seems to be not correct:
In fact, after some tests, it came out that, with the exception of EEF (check also vires_subsetting.xlsx):
The text was updated successfully, but these errors were encountered: