Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET 8 #231

Closed
AkiraVoid opened this issue Dec 23, 2023 · 6 comments · Fixed by #232
Closed

Support .NET 8 #231

AkiraVoid opened this issue Dec 23, 2023 · 6 comments · Fixed by #232

Comments

@AkiraVoid
Copy link
Contributor

I have firstly created an issue in the main repo of FluentEmail, and then I noticed this package is not in the main repo.

To be brief, the older version of Microsoft.Graph does not support .NET 8 which has System.Text.Json 8.0 bundled, and I hope we could upgrade the packages referenced in this project to support .NET 8.

By the way, I also found an discussion in main repo, written by the author of FluentEmail which is asking you if you want to add the source code into their project.

@DavidDeSloovere
Copy link
Member

I'm off work for a couple of days, but already want to comment on separate vs one repo: the official repo did not process or publish the PRs, and we needed this feature. The official repo also doesn't seem to update that frequent.

@AkiraVoid
Copy link
Contributor Author

...The official repo also doesn't seem to update that frequent.

I agree with you. It seems like they haven't done anything since last year.

@DavidDeSloovere
Copy link
Member

Does this prerelease work for you?
https://github.com/ESC-BV/FluentEmail.Graph/pkgs/nuget/FluentEmail.Graph/161977902

If yes, I can publish 2.5 on nuget.

@DavidDeSloovere
Copy link
Member

If forgot how you can add GH as package source. If you don't find it, I can just publish to nuget.

@AkiraVoid
Copy link
Contributor Author

I successfully built my app with the new package.

@DavidDeSloovere
Copy link
Member

Thanks for confirming.
2.5.0 has been pushed to both:

Happy holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants