Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in MUSICA chemistry #49

Open
gold2718 opened this issue May 1, 2020 · 6 comments
Open

Bring in MUSICA chemistry #49

gold2718 opened this issue May 1, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@gold2718
Copy link
Collaborator

gold2718 commented May 1, 2020

Add the MUSICA Chemistry as an external. The test for this functionality will be both a standalone terminator chemistry test and the CAM-SE Held-Suarez terminator chemistry test.

@gold2718 gold2718 added the enhancement New feature or request label May 1, 2020
@K20shores
Copy link
Collaborator

@nusbaume does #225 close this?

@nusbaume
Copy link
Collaborator

I'm not super familiar with the state of the "MUSICA Chemistry" repo, so I'll let @mattldawson decide. However, if he has no strong opinions then I am happy with closing this issue.

@cacraigucar
Copy link
Collaborator

My two cents opinion.

I would say this issue would close when MICM/MUSICA is brought in via the Externals and has a scheme which utilizes it. Normal day-to-day running of MICM/MUSICA will be done outside the container (at least for now), so I suggest it needs to be implemented in this way before we close this issue.

Of course, I'm open to being overridden on this decision.

@nusbaume
Copy link
Collaborator

@cacraigucar I could be wrong, but my understanding is that MUSICA (or at least MICM) would be brought in as a separate library that is independently built on the machine, similar to ESMF or NetCDF. Thus I don't think we'll ever need to bring it in via manage_externals. Now we could wait and close this issue once we have a MICM config file for CAM-SIMA that actually runs some sort of chemical mechanism, but IMO that isn't really what this issue is requesting (I just interpret it as getting the MUSICA library successfully linked to CAM-SIMA).

Of course I am happy to be corrected by any of the ACOM SEs if I have that wrong here.

@mattldawson
Copy link
Collaborator

@cacraigucar @nusbaume I have no strong preference here. We've been trying to work on issues that are sprint-sized or smaller, but we don't have to inflict that everyone else. If this does include running an actual simulation with chemistry (which is more than sprint sized), what we have been doing is adding a checklist to the description for all the sub-tasks, which are then easy to turn into individual issues:

  • step 1
  • step 2
  • step 3

Then, when all the PRs are merged in for the sub-tasks, we close the issue. If you would like to do this, maybe we can come up with the sub tasks during the next sprint planning meeting?

@cacraigucar
Copy link
Collaborator

@cacraigucar @nusbaume I have no strong preference here. We've been trying to work on issues that are sprint-sized or smaller, but we don't have to inflict that everyone else. If this does include running an actual simulation with chemistry (which is more than sprint sized), what we have been doing is adding a checklist to the description for all the sub-tasks, which are then easy to turn into individual issues:

  • step 1
  • step 2
  • step 3

Then, when all the PRs are merged in for the sub-tasks, we close the issue. If you would like to do this, maybe we can come up with the sub tasks during the next sprint planning meeting?

If you would find this useful, feel free to pursue it. It is also okay to have a PR say "Partially addressed #XXX" and not have a specific issue for every PR when there are multiple commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

5 participants