Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get dry-deposition/MEGAN working with FATES-SP mode #1784

Open
2 tasks
ekluzek opened this issue Jun 17, 2022 · 2 comments · Fixed by #1766
Open
2 tasks

Get dry-deposition/MEGAN working with FATES-SP mode #1784

ekluzek opened this issue Jun 17, 2022 · 2 comments · Fixed by #1766
Assignees
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Jun 17, 2022

The most straightforward part of getting FATES to work with dry deposition is to get it to work in FATES-SP mode. This is something that the code is very close to being able to do right now.

This is a particular part of #1044

Definition of done: Have both dry-deposition and MEGAN work in FATES-SP mode.

  • Erik: Go over the code to ensure this is correct
  • Louisa: Verify this looks correct in simulations
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability tag: enh - new science labels Jun 17, 2022
@ekluzek ekluzek changed the title Get dry-deposition working with FATES-SP mode Get dry-deposition/MEGAN working with FATES-SP mode Jul 15, 2022
@ekluzek ekluzek self-assigned this Jul 15, 2022
@ekluzek
Copy link
Collaborator Author

ekluzek commented Jul 15, 2022

Open this up as I need to review the code and make sure all of the data that is used by MEGAN and drydep is set when FATES is on. I've reviewed some of it and it's set, but I should make sure everything is set.

After I do that Louisa will run some simulations and make sure FATES-SP is mode is worked as expected for MEGAN and drydep.

@rosiealice
Copy link
Contributor

I have PRs on the NorESMhub for the Megan and dry deposition code. Both are nearly completed. Probably this task should be split in two for dry and megan…

Thus is a high priority for us running coupled fates simulations, hence we want to pull it into the NorESM fork asap. I will make PRs to the encomp and NGEE repositories as well once it is properly working (getting it to work to allow other things to happen being the highest priority)

Drydep
NorESMhub/fates#11
NorESMhub#88

megan
NorESMhub/fates#10
NorESMhub#74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants