Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make polarcap surface datasets in ctsm5.3.0, remove VR 1850 datasets #2720

Open
2 tasks done
ekluzek opened this issue Aug 22, 2024 · 7 comments · May be fixed by #2500
Open
2 tasks done

Make polarcap surface datasets in ctsm5.3.0, remove VR 1850 datasets #2720

ekluzek opened this issue Aug 22, 2024 · 7 comments · May be fixed by #2500
Assignees
Labels
enhancement new capability or improved behavior of existing capability
Milestone

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 22, 2024

Alongside #2716 we need to add creating 1979,1850,2000,1979-2026 surface datasets for the ne0.POLARCAP resolution. This means adding it to the ne0 and ne120 resolution list in the gen namelist multi script for mksurfdata_esmf.

As part of this we'll remove the 1850 VR datasets as they aren't planned to be needed by CAM as explained by @adamrher

Definition of done:

  • Add polar grid to Makefile
  • Remove creation of 1850 files for VR grids (decided won't do, just won't import the 1850 datasets)
@ekluzek ekluzek added the enhancement new capability or improved behavior of existing capability label Aug 22, 2024
@ekluzek ekluzek added this to the ctsm5.3.0 milestone Aug 22, 2024
@wwieder
Copy link
Contributor

wwieder commented Aug 22, 2024

Is this critical for a 5.3 milestone of does it just need to come in by the CESM3 release?

@ekluzek
Copy link
Collaborator Author

ekluzek commented Aug 22, 2024

Always the right question to ask. In order to have a dataset for @adamrher to use in CTSM5.3 versions we might as well make it. It shouldn't be hard to add, unless we run into problems. So I suggest we do so unless it causes problems in making all the datasets. But, it's likely only needed by the release and not in 5.3.

@ekluzek ekluzek changed the title Make polarcap surface datasets in ctsm5.3.0 Make polarcap surface datasets in ctsm5.3.0, remove VR 1850 datasets Aug 22, 2024
@wwieder
Copy link
Contributor

wwieder commented Aug 29, 2024

This isn't required for 5.3.0, but could be added on subsequent 5.3 tag (or else it needs to get into make_all).

Could add PLUMBER2 and NEON surface data too.

@wwieder wwieder assigned ekluzek and slevis-lmwg and unassigned slevis-lmwg and ekluzek Aug 29, 2024
@slevis-lmwg slevis-lmwg linked a pull request Aug 29, 2024 that will close this issue
63 tasks
@slevis-lmwg
Copy link
Contributor

Confirming info listed here and in the grids speadsheet:

  • no 1850
  • yes 1979, 2000, 1979-2026
  • same for ne0np4.ARCTICGRIS.ne30x8, ne0np4.ARCTIC.ne30x4, ne0np4CONUS.ne30x8, ne0np4.POLARCAP.ne30x4

@adamrher
Copy link
Contributor

Yes, that's correct @slevis-lmwg. I noticed however that CONUS only has finidat entries for year 2013. Perhaps we can just replicate the POLARCAP finidat entries for CONUS?

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Aug 31, 2024

@adamrher thank you for the quick confirmation.

Let's confer with @ekluzek on the finidat question.

@ekluzek does the finidat discussion go under #2558 or other similar issue?

@slevis-lmwg
Copy link
Contributor

From meeting with @ekluzek
Current Makefile generates 1850 fsurdat files for VR grids.
We decided to not mess with the scripts at this time and just not ./rimport the four 1850 fsurdat files.
We can leave this issue open as a reminder to correct gen_mksurfdata_jobscript_multi.py code later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants