Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python sys tests much longer with added tower testing... #2946

Open
ekluzek opened this issue Jan 29, 2025 · 9 comments · May be fixed by #2963
Open

Python sys tests much longer with added tower testing... #2946

ekluzek opened this issue Jan 29, 2025 · 9 comments · May be fixed by #2963
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability performance idea or PR to improve performance (e.g. throughput, memory) test: python Pass clm_pymods test suite plus Python sys/unit tests before merging testing additions or changes to tests

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Jan 29, 2025

#2406 makes the python system testing much longer. It's still less than an hour but a good fraction of it though. This is something that would help our python development and testing if we make it shorter. The reason for the length is really #2885. So fixing it should resolve this.

I'm also wondering about breaking up python system tests to another set of "long_sys" tests, that maybe we don't run as often? And actually if we ran that test list as part of aux_clm hour long testing would be fine.

@ekluzek ekluzek added bfb bit-for-bit enhancement new capability or improved behavior of existing capability next this should get some attention in the next week or two. Normally each Thursday SE meeting. performance idea or PR to improve performance (e.g. throughput, memory) test: python Pass clm_pymods test suite plus Python sys/unit tests before merging testing additions or changes to tests labels Jan 29, 2025
@adrifoster
Copy link
Collaborator

@ekluzek I agree I think we should move the "building" part of this into our aux_clm testing and keep the python system tests quick.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jan 29, 2025

@adrifoster but is it OK for us to bring them in as they are now? And fix it later? Or should we see if we can fix it now? I suppose if it takes too long, it might not be worth it, but it also could be easy to fix. What do you think?

@adrifoster
Copy link
Collaborator

@ekluzek my inclination is to yes bring this in now. we can have a separate PR to move long tests to aux_clm, and then this long testing will get fixed when #2885 is fixed?

@adrifoster
Copy link
Collaborator

@ekluzek to clarify - since this test shouldn't be long I would leave it here (even in that future PR I mentioned)

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jan 29, 2025

Perfect, that is what we will do.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jan 30, 2025

Actually, it only changes the time from about 6 minutes to about 21 minutes, for all of the python sys tests. So better than I was initially thinking...

@ekluzek ekluzek added this to the ctsm6.0.0 (code freeze) milestone Feb 5, 2025
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Feb 13, 2025
@wwieder
Copy link
Contributor

wwieder commented Feb 13, 2025

@samsrabin has a fix for #2885 and he can pull out larger single point work to address this issue

@samsrabin
Copy link
Collaborator

samsrabin commented Feb 13, 2025

In my testing of ctsm5.3.024, test_sys_run_tower.py takes about 871 seconds (n=2). PR #2963 speeds this up by >90% (~82 seconds, n=3). I will mark that PR as closing this issue.

@samsrabin samsrabin linked a pull request Feb 13, 2025 that will close this issue
3 tasks
@samsrabin samsrabin linked a pull request Feb 13, 2025 that will close this issue
3 tasks
@wwieder
Copy link
Contributor

wwieder commented Feb 13, 2025

Thanks for doing this quickly, Sam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability performance idea or PR to improve performance (e.g. throughput, memory) test: python Pass clm_pymods test suite plus Python sys/unit tests before merging testing additions or changes to tests
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

4 participants