-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python sys tests much longer with added tower testing... #2946
Comments
@ekluzek I agree I think we should move the "building" part of this into our aux_clm testing and keep the python system tests quick. |
@adrifoster but is it OK for us to bring them in as they are now? And fix it later? Or should we see if we can fix it now? I suppose if it takes too long, it might not be worth it, but it also could be easy to fix. What do you think? |
@ekluzek to clarify - since this test shouldn't be long I would leave it here (even in that future PR I mentioned) |
Perfect, that is what we will do. |
Actually, it only changes the time from about 6 minutes to about 21 minutes, for all of the python sys tests. So better than I was initially thinking... |
@samsrabin has a fix for #2885 and he can pull out larger single point work to address this issue |
In my testing of ctsm5.3.024, |
Thanks for doing this quickly, Sam. |
#2406 makes the python system testing much longer. It's still less than an hour but a good fraction of it though. This is something that would help our python development and testing if we make it shorter. The reason for the length is really #2885. So fixing it should resolve this.
I'm also wondering about breaking up python system tests to another set of "long_sys" tests, that maybe we don't run as often? And actually if we ran that test list as part of aux_clm hour long testing would be fine.
The text was updated successfully, but these errors were encountered: