Guidelines for MOSART Pull Requests

[ekluzek]

Roles for MOSART maintenance:

• The Land Model Working Group of CESM (LMWG) is responsible for maintenance of the river models in CESM (RTM, MOSART, and mizuRoute)
• LMWG NCAR chair (currently @wwieder) manages the scientific priorities of development within the river models, including management of SE activities in that space.
• LMWG is responsible for scientific development in river models, with @swensosc being the scientific lead for MOSART scientific development
• The CTSM SE group is the group responsible for MOSART maintenance. We will address them as MOSART maintainers hereafter.
• MOSART maintainers will work with the LMWG chair on the needed SE developments in the river models and is responsible for: tag ordering, tags, testing-requirements, and testing baselines. This group will be the one that normally does these activities, however external collaborators can be given access with some training and oversight from MOSART maintainers. Right now the individuals that will normally do this work is: @slevis-lmwg and/or @ekluzek.
• External collaborators will submit PR's to river models and be informed on the ordering for them from MOSART maintainers.
• MOSART maintainers need to approve PR's to river models if only so they are informed on what is happening.
• MOSART maintainers are responsible to manage adding river model tags into CESM with the CSEG group testdb and coordinating with CTSM tags.
• The prioritization of of MOSART Pull Requests (PR's) and attention from MOSART maintainers is subject to the prioritization of broader priorities of the LMWG (that are ultimately managed by the LMWG co-chairs, SEs, and liaisons).
• mizuRoute is the planned successor to both RTM and MOSART, so you might first ask if changes in MOSART should really go into mizuRoute, rather than MOSART.-

Using the same guidelines as for CTSM:

• As stated above the LMWG drives the maintenance of MOSART and as such the guidelines for CTSM apply here to MOSART
• https://github.com/ESCOMP/CTSM/wiki/CTSM-PR-Expectations

Overall process for MOSART Pull Requests (PR's):

• MOSART PR's may be merged together into one merge tag by MOSART maintainers. The tags merged together needs to be well tested and baselines updated (see MOSART Tagging Process #83)
• It's preferred that simple non-bit-for-bit changes be put into a single PR
• It's preferred that PR's be broken up into related changes (which makes it easier to review)
• MOSART maintainers may make changes to a PR, but will ask permission for the author first, and if the author needs to review will open up a PR to the PR to ESCOMP. Maintainers will prefer using the method given at first of merging several PR's together to create a tag.
• It's preferred that collaborators communicate with MOSART maintainers about PR's they have coming in.
• Since queuing of MOSART tags is managed by the CTSM SE group under the authority of LMWG and LMWG NCAR chair -- the tag ordering will be decided from that group.
• MOSART maintainers will communicate with authors about the ordering of their PR's into tags
• MOSART maintainers should communicate with authors about any changes to the plans
• MOSART maintainers should update authors when PR's are scheduled to come into the current development cycle and it hasn't happened in six weeks.

[ekluzek]

@mvertens @jedwards4b @slevis-lmwg @swensosc please give feedback on the above. Once, we think it's settled I'll remove the extraneous discussion and lock this discussion. We can still edit later, but we'll need to use other communication means to discuss it...