Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of models from URL is discarded as soon as you start interacting with the map #3

Open
bouweandela opened this issue Mar 11, 2022 · 5 comments

Comments

@bouweandela
Copy link
Member

Issue reported by @aspinuso: I noticed that the user’s choice for the models is discarded as soon as you start interacting with the map. Not sure whether this can ben improved. Only by refreshing the page the list of models are read from the query string and they show up again.

@bouweandela
Copy link
Member Author

@Peter9192 Do you think it would be easy to improve this?

@Peter9192
Copy link
Collaborator

I think this is intended behavior, no? The query sets the original selection, then you can play. There's no point in keeping the original selection.

It would be more intuitive to first explore this graph and only then take the result back to the C4I portal, but this is what we agreed upon...

@aspinuso
Copy link

yes, we agreed that you can play and see the performance of the other models. But I guess what I mean, is that you miss immediately the focus on what you have just decided to compare. Interactively, it just felt weird to me to loose that state.

@Peter9192
Copy link
Collaborator

So you'd prefer to keep to dataset listing at the bottom fixed. And then what about the selection? Fix the initial selection and limit further interaction to hovering?

@aspinuso
Copy link

aspinuso commented Mar 16, 2022

Hi, I would keep the datasets listing at bottom and the related markers on the plot highlighted (with the contour already used), while zooming and hoovering, no particular limitation then. So users can evaluate the alternatives in respect to what they had initially selected. So I would not limit any other interaction, just keep the initial state consistent. Then they can go back to the portal and change or add more models. I think this would keep the two systems/pages consistent at this stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants