-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use our own unit conversion function in our fixes #2560
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2560 +/- ##
==========================================
+ Coverage 94.77% 94.79% +0.02%
==========================================
Files 251 251
Lines 14266 14280 +14
==========================================
+ Hits 13520 13537 +17
+ Misses 746 743 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Manu 🐊 A few questions I have, unfortunately all packed into a comment 🍺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spiffy! Still, no alligators 😢 🐊
@ESMValGroup/technical-lead-development-team could one of yous please have a last look at this then merge? 🍺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @schlunma, thanks for fixing this.
Description
While performing tests for ESMValGroup/ESMValTool#3784, I noticed that our fixes do not use our own unit conversion function, which allows special unit conversions like m -> DU.
This PR adds this, but uses a "safe" version of the unit conversion which will not allow a change of the cube's
standard_name
(this would lead to errors in the subsequent CMOR checks).Note: I had to restructure the functions a little bit to avoid circular imports.
Related to
DU
to recipes that usetoz
ESMValTool#3784toz
) more flexible and add derivation of stratospheric and tropospheric column ozone #2509Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: