Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how to add a recipe documentation #3074

Closed
mo-tgeddes opened this issue Mar 7, 2023 · 2 comments · Fixed by #3614
Closed

Add how to add a recipe documentation #3074

mo-tgeddes opened this issue Mar 7, 2023 · 2 comments · Fixed by #3614
Assignees
Labels
Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow

Comments

@mo-tgeddes
Copy link
Contributor

Part of #2786.
Add instructions on how to add a recipe to the recipe test workflow, to the documentation

@mo-tgeddes mo-tgeddes added the Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow label Mar 7, 2023
@mo-tgeddes mo-tgeddes self-assigned this Mar 7, 2023
@ehogan
Copy link
Contributor

ehogan commented May 2, 2024

@alistairsellar's notes for this:

Adding a recipe to RTW:

  • Check it works offline on Jasmin (which should have complete set of obs and model data)
    • Offline means outside the RTW
    • Run with time and check time & mem at the end (esmvaltool provides memory estimate)
  • Get it running offline on Met Office: download obs and model data
  • Document memory and time on each platform in
  • Stop RTW on Met Office & Jasmin
  • Add to RTW on Met Office (update start date to today) & run
  • When compare fails:
    • copy output from $HOME/cylc-run/recipe_test_workflow/runN/share/cycle// to KGO directory (see opt/rose-suite-metoffice.conf)
    • then chmod a+w
  • Re-trigger compare task
  • If it succeeds, commit and push
  • Pull on jasmin and run
  • When compare fails:
    • copy output to /gws/nopw/j04/esmeval/KGO/
    • then chmod a+w

@mo-gill
Copy link
Contributor

mo-gill commented May 22, 2024

During completion of issue #3608 using Alistair's instructions, i made some modifications to them to start shaping them further into final instructions. Hopefully they're helpful:

  1. Run "esmvaltool run <recipename.yml>" (if it raises error about missing data, then data will need to be retrieved so it can be run).

  2. Run the same on jasmin.

  3. Take note of output of time and memory taken to run for both by checking cylc review .

  4. Use "cylc stop" to stop the running rtw workflows.

  5. Add the recipe to the RTW flow.cylc file.

  6. Add time/memory usage to the metoffice.cylc and jasmin.cylc if they are larger than the defaults, this can be found in "job.time" in cylc review.

  7. Run the workflow with cylc vip -O metoffice (it will fail).

  8. Locate it's run folder.

  9. Copy the output of that recipe run from that cycle (run/share/bin/cycle into KGO rootpath folder (KGO_ROOT_PATH="/data/users/esmval/KGO").

    cp -r <directory of recipe from it's cycle in run directory>

  10. Cd to KGO folder.

  11. Use "chmod a+w on recipe you've just added in KGO folder.

  12. Run RTW again.

  13. If the workflow now succeeds, commit and push.

mo-gill added a commit that referenced this issue May 27, 2024
mo-gill added a commit that referenced this issue May 29, 2024
mo-gill added a commit that referenced this issue May 29, 2024
mo-gill added a commit that referenced this issue May 29, 2024
mo-gill added a commit that referenced this issue Jun 4, 2024
mo-gill added a commit that referenced this issue Jun 4, 2024
mo-gill added a commit that referenced this issue Jun 4, 2024
mo-gill added a commit that referenced this issue Jun 19, 2024
mo-gill added a commit that referenced this issue Jun 19, 2024
mo-gill added a commit that referenced this issue Jun 20, 2024
mo-gill added a commit that referenced this issue Jun 21, 2024
mo-gill added a commit that referenced this issue Jun 21, 2024
mo-gill added a commit that referenced this issue Jun 21, 2024
mo-gill added a commit that referenced this issue Jun 21, 2024
mo-gill added a commit that referenced this issue Jun 21, 2024
mo-gill added a commit that referenced this issue Jun 21, 2024
mo-gill added a commit that referenced this issue Jun 24, 2024
mo-gill added a commit that referenced this issue Jun 24, 2024
mo-gill added a commit that referenced this issue Jun 24, 2024
mo-gill added a commit that referenced this issue Jun 24, 2024
mo-gill added a commit that referenced this issue Jun 24, 2024
mo-gill added a commit that referenced this issue Jun 25, 2024
ehogan added a commit that referenced this issue Jun 25, 2024
@ehogan ehogan linked a pull request Jun 25, 2024 that will close this issue
2 tasks
@ehogan ehogan closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants