Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD TestResult element to OpXXXActualType in OperationsPerformanceTypes.xsd to align with updated 950002 #16

Open
racheliurui opened this issue Aug 21, 2019 · 3 comments
Assignees
Labels
ERDi Issues that need to be fixed in ERDi version Low MESA Issues that need to be fixed in MISA Version

Comments

@racheliurui
Copy link
Collaborator

racheliurui commented Aug 21, 2019

Background
ERDi, MESA: Related to #7, #101

  1. Align TestResult element with updated 950002, Operations Test Model where the Test Result object has an association relationships with the resource actual objects.
    Under issue Add OperationsTest.xsd to align with updated 950002 #101, the new OperationsTest.xsd schema is added to align with 950002 by including TestSpecificationType and TestResultType together which allows 1st order transactions for both types.

  2. B2MML 7.0 beta only created a B2MML-TestSpecification.xsd schema and created the complex types of "TestResultType" and TestPropertyMeasurementType in the Common Schema.

  3. HOWEVER, B2MML 7.0 still has the TestResult element in each instance resource property per the old version of ISA-95 resource models and B2MML 6.0. The old resource model had a composite relationship from the each resource property of the resource master data objects which did not allow Test Result attribute to be exchanged and queried as a 1st class object. This design has the logic issue where a test result is related to testing of a resource actual to a master data resource's test specification. The old resource models had a composite relationship which did not allow Test Result to be exchanged and queried as a 1st class object.

Supporting Documents
Clause 6.3.6 Personnel actual, Table 208 – Personnel actual relationship roles
Clause 6.3.8 Equipment actual, Table 212 – Equipment actual relationship roles
Clause 6.3.10 Physical asset actual, Table 216 – Physical asset actual relationship roles
Clause 6.3.12 Material actual, Table 220 – Material actual relationship roles

Impacted Type and Solutions
_OperationsPerformanceTypes.xsd,

  • OpPersonnelActualType"
  • OpMaterialActualType"
  • OpEquipmentActualType"
  • OpPhysicalAssetActualType"_
    ADD: "TestResult" type = "TestResultType" to align with updated Part 2 Operations Test Model's relationships.
racheliurui referenced this issue Aug 21, 2019
Updated TestResultTypoe and PropertyMeasurementType.
@racheliurui racheliurui added ERDi Issues that need to be fixed in ERDi version MESA Issues that need to be fixed in MISA Version labels Aug 21, 2019
@racheliurui racheliurui added this to the Discussed & Commented milestone Aug 22, 2019
@racheliurui
Copy link
Collaborator Author

racheliurui commented Aug 22, 2019

  • Supporting Standard
    Additions to TestResultType in Common.xsd:
    950002, Section 5.9.8, Table 111 and 112 for .
    Additions of TestResult to Resource Actuals in OperationsPerformanceTypes.xsd:
    950002, Section 6.3.6 Personnel actual (Table 208), 6.3.8 Equipment actual (Table 212), 6.3.10 Physical asset actual (Table 216), 6.3.12 Material actual (Table 220)

@racheliurui
Copy link
Collaborator Author

racheliurui commented Aug 22, 2019

Pending discussion and linked issues,

@racheliurui racheliurui changed the title TestResultType: Align with ISA-950002 TestResultType attribute Align with ISA-950002 Aug 23, 2019
@CharlieG021163 CharlieG021163 changed the title TestResultType attribute Align with ISA-950002 Change TestResultType in Common.xsd and/or Approve Pull Request for OperationsTest.xsd align with updated 950002 Jan 23, 2020
@CharlieG021163 CharlieG021163 changed the title Change TestResultType in Common.xsd and/or Approve Pull Request for OperationsTest.xsd align with updated 950002 ADD TestResult to OpXXXActualType in OperationsPerformanceTypes.xsd to align with updated 950002 Mar 5, 2020
@CharlieG021163 CharlieG021163 changed the title ADD TestResult to OpXXXActualType in OperationsPerformanceTypes.xsd to align with updated 950002 ADD TestResult element to OpXXXActualType in OperationsPerformanceTypes.xsd to align with updated 950002 Mar 5, 2020
racheliurui referenced this issue Mar 9, 2020
ERDi, MESA:  complexType name = "OpPersonnelActualType", ADD element name = "TestResultType", CHANGE element name = "PersonnelActual" to "PersonnelActualChild";  DELETE = element name = "TestSpecification".

ERDi, MESA:  complexType name = "OpMaterialActualType", ADD element name = "TestResultType"; CHANGE element name = "MaterialActual" to "MaterialActualChild";  DELETE = element name = "TestSpecification".

ERDi, MESA:  complexType name = "OpEquipmentActualType", ADD element name = "TestResultType", CHANGE element name = "EquipmentActual" to "EquipmentActualChild"

ERDi, MESA: complexType name = "OpPhysicalAssetActualType", ADD element name = "TestResultType"; ADD element name = "PhysicalAssetActualProperty"; CHANGE element name = "PhysicalAssetActual" to "PhysicalAssetActualChild";  DELETE = element name = "TestSpecification".

ERDi, MESA: complexType name =  OpPersonnelActualPropertyType", ADD element name = "PersonnelActualPropertyChild";  ADD element name = "PersonnelClassPropertyID";  ADD element name = "PersonPropertyID";  DELETE element name = "RequiredByRequestedSegmentResponse"

ERDi, MESA: complexType name =  OpMaterialActualPropertyType", ADD element name = "MaterialActualPropertyChild";  ADD element name = "MaterialLotPropertyID";  ADD element name = "MaterialDefinitionPropertyID";  ADD element name = "MaterialClassPropertyID"; DELETE element name = "RequiredByRequestedSegmentResponse"

ERDi, MESA: complexType name =  OpEquipmentActualPropertyType", ADD element name = "EquipmentActualPropertyChild";  ADD element name = "EquipmentClassPropertyID";  ADD element name = "EquipmentPropertyID"; DELETE element name = "RequiredByRequestedSegmentResponse"

ERDi, MESA: complexType name =  OpPhysicalAssetActualPropertyType", ADD element name = "PhysicalAssetActualPropertyChild";  ADD element name = "PhysicalAssetClassPropertyID";  ADD element name = "PhysicalAssetPropertyID";  DELETE element name = "RequiredByRequestedSegmentResponse"
@Dennis-Brandl
Copy link

I agree with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ERDi Issues that need to be fixed in ERDi version Low MESA Issues that need to be fixed in MISA Version
Projects
None yet
Development

No branches or pull requests

5 participants