Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TestPropertyMeasurementType to PropertyMeasurementType in Common.xsd (if OperationsTest.xsd not used) to align with updated 950002 Operations Test #17

Open
racheliurui opened this issue Aug 21, 2019 · 6 comments
Assignees
Labels
ERDi Issues that need to be fixed in ERDi version Medium MESA Issues that need to be fixed in MISA Version

Comments

@racheliurui
Copy link
Collaborator

racheliurui commented Aug 21, 2019

Background and Solution
ERDi, MESA: Related to #101
To align with updated 950002 Operations Test Model's relationships.
Align TestResult element with updated 950002, Operations Test Model where the Test Result object has an association relationships with the resource actual objects.
Under issue #101, the new OperationsTest.xsd schema is added to align with 950002 by including TestSpecificationType and TestResultType together which allows 1st order transactions for both types.

Solution
IF MESA does not except this change, the following change is recommended to Common.xsd.
CHANGE: "TestPropertyMeasurementType" with "PropertyMeasurementType"

Impacted Types
Common.xsd
TestPropertyMeasurementType

Supporting Document
950002 JWG5 CDV01 version (2019 12)
Clause 5.9.9, Property measurement, Table 114 Property measurement attributes.

racheliurui referenced this issue Aug 21, 2019
Updated TestResultTypoe and PropertyMeasurementType.
@racheliurui
Copy link
Collaborator Author

racheliurui commented Aug 21, 2019

  • Supporting Document

ISA-950002
Section 5.9.9
Table 114 Property measurement attributes

@racheliurui racheliurui added ERDi Issues that need to be fixed in ERDi version MESA Issues that need to be fixed in MISA Version labels Aug 21, 2019
@racheliurui racheliurui added this to the Discussed & Commented milestone Aug 22, 2019
@racheliurui
Copy link
Collaborator Author

racheliurui commented Aug 22, 2019

@CharlieG021163 the latest version at draft branch have a typo problem (missing "minOccurs = "0" nillable="true"/>") at line 1540, could you please fix it? or do you want me to fix it?

<xsd:element name = "ID" type = "IdentifierType"

@racheliurui
Copy link
Collaborator Author

@CharlieG021163 If you change the name from "TestPropertyMeasurementType" to "PropertyMeasurement", should you also change the last element for PropertyMeasurement to something like,

<xsd:group   ref  = "Extended:PropertyMeasurement" minOccurs="0" maxOccurs="1"/> 

and also change the

<xsd:group name = "TestPropertyMeasurement">

to

    <xsd:group name = "PropertyMeasurement">

@CharlieG021163
Copy link
Collaborator

Yes, WIP. Thanks.

@racheliurui
Copy link
Collaborator Author

Agreed

@CharlieG021163 CharlieG021163 changed the title Replace "TestPropertyMeasurementType" with "PropertyMeasurement" Change TestPropertyMeasurementType to "PropertyMeasurementType in Common.xsd to align with updated 950002 Operations Test Jan 23, 2020
@CharlieG021163 CharlieG021163 changed the title Change TestPropertyMeasurementType to "PropertyMeasurementType in Common.xsd to align with updated 950002 Operations Test Change TestPropertyMeasurementType to PropertyMeasurementType in Common.xsd to align with updated 950002 Operations Test Jan 23, 2020
@CharlieG021163 CharlieG021163 changed the title Change TestPropertyMeasurementType to PropertyMeasurementType in Common.xsd to align with updated 950002 Operations Test Change TestPropertyMeasurementType to PropertyMeasurementType in Common.xsd (if OperationsTest.xsd not used) to align with updated 950002 Operations Test Mar 9, 2020
@Dennis-Brandl
Copy link

I agree with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ERDi Issues that need to be fixed in ERDi version Medium MESA Issues that need to be fixed in MISA Version
Projects
None yet
Development

No branches or pull requests

5 participants