Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TestSpecificationEvaluatedPropertyType to EvaluatedPropertyType in TestSpecification.xsd (if OperationsTest.xsd not used) and add relationship role elements to align with updated 950002 #25

Open
racheliurui opened this issue Aug 23, 2019 · 3 comments
Assignees
Labels
ERDi Issues that need to be fixed in ERDi version Medium MESA Issues that need to be fixed in MISA Version

Comments

@racheliurui
Copy link
Collaborator

racheliurui commented Aug 23, 2019

Background

ERDI, MESA: Related to #101
TestSpecification.xsd
Background
Align TestResult element with updated 950002, Operations Test Model where the Test Result object has an association relationships with the resource actual objects.
Under issue #101, the new OperationsTest.xsd schema is added to align with 950002 by including TestSpecificationType and TestResultType together which allows 1st order transactions for both types.
Solution
IF MESA does not except OperationsTest.xsd change, the following change is recommended to TestSpecification.xsd.

CHANGE complexType name = "TestSpecificationEvaluatedPropertyType" to "EvaluatedPropertyType" to match explicit name of object to align with updated 950002 Operations Test Model's Test Specification object and EvaluatedProperty object.

ERDI, MESA: TestSpecification.xsd, complexType name = "EvaluatedPropertyType",
ADD "TestableObjectPropertyID" element to align with updated 950002 Operations Test Model's relationships for the Test Specification object and EvaluatedProperty object.

Impacted Types

B2MML-TestSpecification.xsd

  • TestSpecificationEvaluatedPropertyType (existing)

Supporting Document

950002 JWG5 CDV01 version (2019 12)
Clause 5.9.7 Evaluated property, Table 109 – Evaluated property relationship roles

racheliurui referenced this issue Aug 23, 2019
Updated TestSpecification.xsd with relationships to TestableObject and OperationsTestRequirement.
@racheliurui racheliurui added ERDi Issues that need to be fixed in ERDi version MESA Issues that need to be fixed in MISA Version labels Aug 23, 2019
@racheliurui racheliurui changed the title Change TestSpecificationEvaluatedPropertyType to EvaluatedPropertyType and modify the elelement to align with ISA-950002 Change TestSpecificationEvaluatedPropertyType to EvaluatedPropertyType and modify the EvaluatedPropertyType to align with ISA-950002 Aug 23, 2019
@racheliurui
Copy link
Collaborator Author

TestSpecificationEvaluatedPropertyType/Extended:TestSpecificationEvaluatedProperty
should be change as
EvaluatedProperty/Extended:EvaluatedProperty
9cbeeb3#diff-073d1396ed9dba5010ab3251cf59ec82L206

racheliurui referenced this issue Aug 26, 2019
ERDi, MESA: Fix typeOs.

Issue raised:  B2MML 7.0 beta has created a B2MML-TestSpecification.xsd schema and created the complex types of "TestResultType" and TestPropertyMeasurementType in the Common Schema.
B2MML 7.0 still has the TestResult type as an attribute in each instance resource property per the old version of ISA-95 resource models and B2MML 6.0. This was a composite relationship which did not allow Test Result to be exchanged and queried as a 1st class object.
In the new Operations Test Model in updated Part 2, Test Result is a 1st order object that is able to be exchanged/queried.
The MESA Committee may reject changing their implementation. If so, ERDi should create an OperationsTest.xsd schema that has test specification type and test result type and allow 1st order transactions. I do not believe that the 1st order transaction were added to the updated part 5. But the updated part 2 as part of the collaboration with OAGi viewed Test Results as a 1st order object.
@CharlieG021163 CharlieG021163 added this to the AgreedByWorkingGroup milestone Sep 3, 2019
@CharlieG021163 CharlieG021163 changed the title Change TestSpecificationEvaluatedPropertyType to EvaluatedPropertyType and modify the EvaluatedPropertyType to align with ISA-950002 Change TestSpecificationEvaluatedPropertyType to EvaluatedPropertyType in TestSpecification.xsd and add relationship role elements to align with updated 950002 Jan 22, 2020
@gerardmoloneyetpartners
Copy link
Collaborator

agreed

@CharlieG021163 CharlieG021163 changed the title Change TestSpecificationEvaluatedPropertyType to EvaluatedPropertyType in TestSpecification.xsd and add relationship role elements to align with updated 950002 Change TestSpecificationEvaluatedPropertyType to EvaluatedPropertyType in TestSpecification.xsd (if OperationsTest.xsd not used) and add relationship role elements to align with updated 950002 Mar 9, 2020
@Dennis-Brandl
Copy link

I agree with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ERDi Issues that need to be fixed in ERDi version Medium MESA Issues that need to be fixed in MISA Version
Projects
None yet
Development

No branches or pull requests

5 participants