Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete elements, OperationsRequestID from JobOrderType in WorkSchedule.xsd to align with updated 950004 #90

Open
CharlieG021163 opened this issue Dec 9, 2019 · 6 comments
Assignees
Labels
ERDi Issues that need to be fixed in ERDi version High MESA Issues that need to be fixed in MISA Version

Comments

@CharlieG021163
Copy link
Collaborator

CharlieG021163 commented Dec 9, 2019

Background
To align with Updated Work Schedule Model, Job Order object does not have cross model relationships with Operations Request. The Job Order has reference to the Operations Request through the Segment Requirement.

Solution
complexType name = "JobOrderType"
DELETE: <xsd:element name = "OperationsRequestID" type = "IdentifierType" minOccurs = "0" maxOccurs = "unbounded"/>

Supporting Document
950004 JWG5 CDV01 version (2019 12)
Clause 7.6 Job Order, Table 58 – Job order relationship roles

Impacted Types
B2MML WorkSchedule.xsd: "JobOrderType"

CharlieG021163 added a commit that referenced this issue Dec 9, 2019
1. ERDi, MESA:  complexType name = "WorkScheduleType".  Align with updated 950002 and 950004.
CHANGE: #12 element name = "WorkSchedule" 
TO:  element name = "WorkScheduleChild" 

2.  ERDi, MESA:  complexType name = "WorkRequestType".  Align with updated 950002 and 950004.
CHANGE: #12 element name = "WorkRequest" 
TO:  element name = "WorkRequestChild" 

3.  ERDi, MESA:  complexType name = "JobOrderType".  Align with updated 950002 and 950004.
CHANGE:  #82 <xsd:element name = "WorkMasterID"  type = "IdentifierType"/>
TO:  type = "IdentifierType" = "0"/>

4.  ERDi, MESA:  complexType name = "JobOrderType".  Align with updated 950002 and 950004.
DELETE: #90 <xsd:element name = "OperationsRequestID"  type = "IdentifierType"   minOccurs = "0" maxOccurs = "unbounded"/>
@gerardmoloneyetpartners
Copy link
Collaborator

Supporting Document should be Table 58 as per below...
950004, Clause 7.6 Job Order, Table 58 – Job order relationship roles

@gerardmoloneyetpartners
Copy link
Collaborator

Agreed with solution.

I would like to rehash the 'RequiredbyResquestedSegmentResponse" (listed in WS, WD, WE) and the SegmentResponse (listed in the OS).

Question: is the 'SegmentResponse" in the OS a complete set of empty SegmentResponse that the OS is asking to be used in the reporting (e.g. future message of WS, WD, WE and PT?)
Are all of the "RequiredByRequestedSegmentResponse" elements in the WS, WD, WE supposed to list the "SegmentResponseID" from the OS? or are they supposed to list the 'WorkRequestID"? Or a just a Yes/No reference?

@CharlieG021163
Copy link
Collaborator Author

@gerardmoloneyetpartners
We will discuss in next session the accepted with modification comment on Requested Segment Response approach. It is Table 58 in updated JWG5 IEC version based addition of table as part of approved comments at ISA95 October 2019 Meeting. Final approved ISA version of 2018 used Table 57.

@CharlieG021163
Copy link
Collaborator Author

@gerardmoloneyetpartners
Updated original comment to Table 58. Issue is that ALL the issue will need to updated to JWG5 Voting Draft 1 version of 950004. Will discuss this as convention before running through.

@CharlieG021163 CharlieG021163 added ERDi Issues that need to be fixed in ERDi version MESA Issues that need to be fixed in MISA Version High labels Jan 5, 2020
@gerardmoloneyetpartners
Copy link
Collaborator

Agreed to fix.

OpsSchedule will be including both options for segment response to provide either a yes/no (Required, Optional, other) or to provide the actual template of elements.
all other references in other schemas of 'RequiredByRequestedSegmentResponse' are only flags (Required, Optional, Other).

@Dennis-Brandl
Copy link

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ERDi Issues that need to be fixed in ERDi version High MESA Issues that need to be fixed in MISA Version
Projects
None yet
Development

No branches or pull requests

4 participants