Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specific property element names to WorkAlertDefinitionType and WorkAlertType in WorkAlert.xsd to align with 950004. #92

Open
CharlieG021163 opened this issue Dec 9, 2019 · 3 comments
Open

Add specific property element names to WorkAlertDefinitionType and WorkAlertType in WorkAlert.xsd to align with 950004. #92

CharlieG021163 opened this issue Dec 9, 2019 · 3 comments
Assignees
@gerardmoloneyetpartners
Labels
ERDi Issues that need to be fixed in ERDi version High MESA Issues that need to be fixed in MISA Version
Milestone
AcceptedByMESA

Comments

@CharlieG021163
Copy link
Collaborator

CharlieG021163 commented Dec 9, 2019 •
edited
Loading

Related to #60
Background
Currently B2MML WorkAlert.xsd has a common "property" element name for both WorkAlertDefinitionType and WorkAlertType. This confusing. Change name to match align with Work Alert Model in 950004.

Impacted Types and Solutions
B2MML-WorkAlert.xsd
complexType name = "WorkAlertDefinitionType">
CHANGE: <xsd:element name = "Property" type = "WorkAlertPropertyType" minOccurs = "0" maxOccurs = "unbounded"/>
TO: <xsd:element name = "WorkAlertDefinitionProperty" type = "WorkAlertDefinitionPropertyType" minOccurs = "0" maxOccurs = "unbounded"/>

complexType name = "WorkAlertType">
CHANGE: <xsd:element name = "Property" type = "WorkAlertPropertyType" minOccurs = "0" maxOccurs = "unbounded"/>
TO: <xsd:element name = "WorkAlertProperty" type = "WorkAlertPropertyType" minOccurs = "0" maxOccurs = "unbounded"/>

Supporting Document
ISA-950004 JWG5 CDV01 version (2019 12)
Clause 12.2 Work alert definition, Table 78 – Work alert definition relationship roles
Clause 12.4 Work alert, Table 83 – Work alert relationship roles

Impacted Types
B2MML-WorkAlert.xsd
@CharlieG021163 CharlieG021163 changed the title Add specific property element names to WorkAlertDefinitionType and WorkAlertType to align with 940002. Add specific property element names to WorkAlertDefinitionType and WorkAlertType to align with 950004. Dec 9, 2019
CharlieG021163 added a commit that referenced this issue Dec 9, 2019
@CharlieG021163
Update B2MML-WorkAlert.xsd
6d244bb 
ERDi, MESA: complexType name = "WorkAlertDefinitionType">
CHANGE: #92 <xsd:element name = "Property" type = "WorkAlertPropertyType"  minOccurs = "0" maxOccurs = "unbounded"/>
TO: <xsd:element name = "WorkAlertDefinitionProperty" type = "WorkAlertPropertyType"  minOccurs = "0" maxOccurs = "unbounded"/>

ERDi, MESA: complexType name = "WorkAlertType">
CHANGE: #92 <xsd:element name = "Property" type = "WorkAlertPropertyType"  minOccurs = "0" maxOccurs = "unbounded"/>
TO: <xsd:element name = "WorkAlertProperty" type = "WorkAlertPropertyType"  minOccurs = "0" maxOccurs = "unbounded"/>
@CharlieG021163 CharlieG021163 added ERDi Issues that need to be fixed in ERDi version High MESA Issues that need to be fixed in MISA Version labels Jan 3, 2020
@CharlieG021163 CharlieG021163 added this to the Discussed & Commented milestone Jan 3, 2020
@gerardmoloneyetpartners
Copy link
Collaborator

GM to review before giving thumbs up.

@gerardmoloneyetpartners
Copy link
Collaborator

Agreed

@CharlieG021163 CharlieG021163 changed the title Add specific property element names to WorkAlertDefinitionType and WorkAlertType to align with 950004. Add specific property element names to WorkAlertDefinitionType and WorkAlertType in WorkAlert.xsd to align with 950004. Jan 28, 2020
CharlieG021163 added a commit that referenced this issue Jan 29, 2020
@CharlieG021163
#92 In support of updated WorkAlert.xsd, Extensions.xsd, ADD: <xsd:gr…
26e96d4 
…oup name = "WorkAlertDefinitionProperty">
@CharlieG021163 CharlieG021163 mentioned this issue Jan 29, 2020
Open
@Dennis-Brandl
Copy link

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerardmoloneyetpartners gerardmoloneyetpartners

Labels
ERDi Issues that need to be fixed in ERDi version High MESA Issues that need to be fixed in MISA Version
Projects
None yet
Milestone
AcceptedByMESA
Development

No branches or pull requests
4 participants
@terryrankine @CharlieG021163 @Dennis-Brandl @gerardmoloneyetpartners