Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth module crashes when validate_token times out #1024

Open
wku12 opened this issue Jan 24, 2025 · 1 comment
Open

Auth module crashes when validate_token times out #1024

wku12 opened this issue Jan 24, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@wku12
Copy link
Contributor

wku12 commented Jan 24, 2025

Describe the bug

It seems that EverestTimeoutError is not handled in Auth module:

Jan 24 10:51:23 everest-manager[23420]: {"SEVERITY": "ERRO", "SYSLOG_IDENTIFIER": "auth:Auth      ", "CODE_FILE": "", "CODE_LINE": "", "MESSAGE": "Timeout while waiting for result of xxx->token_validator:auth_token_validator->validate_token()"}
Jan 24 10:51:23 everest-manager[23420]: terminate called after throwing an instance of 'boost::wrapexceptEverest::EverestTimeoutError'
Jan 24 10:51:23 everest-manager[23420]:  what():  Timeout while waiting for result of xxx->token_validator:auth_token_validator->validate_token()
Jan 24 10:51:26 systemd-coredump[24275]: [🡕] Process 23420 (auth:Auth) of user 0 dumped core.
Jan 24 10:51:26 everest-manager[23390]: {"SEVERITY": "CRIT", "SYSLOG_IDENTIFIER": "manager        ", "CODE_FILE": "", "CODE_LINE": "", "MESSAGE": "Module auth (pid: 23420) exited with status: 134. Terminating all modules."}

EVerest Domain

Authorization

Affected EVerest Module

Auth

To Reproduce

Steps to reproduce:

  1. Call validate_token and do not reply within timeout

Anything else?

No response

@wku12 wku12 changed the title Auth module crashes when validate_token timesout Auth module crashes when validate_token times out Jan 24, 2025
@hikinggrass hikinggrass added the bug Something isn't working label Jan 24, 2025
@hikinggrass hikinggrass self-assigned this Jan 24, 2025
@hikinggrass
Copy link
Contributor

Thanks for raising this issue, that's indeed something that needs addressing. There's a slightly related PR in everest-framework that makes handling the exceptions that can occur during command calls a bit more explicit but even then the handling ultimately needs to be done in the caller. This would mean having try-catch blocks around command calls and the appropriate error handling/recovering logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants