[fix] Fix parameter set serialization #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acy feature) - Improve get_next_page unit test to confirm parameters are altered
jchen293
approved these changes
Aug 31, 2023
nwithan8
deleted the
512-bug-editing-property-values-on-parameters-failing-subsequent-calls-to-paginated-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RE: #512
Removes an unneeded null check (from an earlier implementation of parameter sets) that was causing reused parameter sets for GetNextPage functionality to not be updated correctly.
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.