Merge pull request #266 from Eclalang/issue-#228-refactor-tests

Issue #228 refactor tests
Eclalang · Feb 26, 2024 · 63473b9 · 63473b9
2 parents 5dabc64 + 4612b22
commit 63473b9
Show file tree

Hide file tree

Showing 5 changed files with 1,602 additions and 205 deletions.
diff --git a/interpreter/eclaType/bool_test.go b/interpreter/eclaType/bool_test.go
@@ -236,12 +236,12 @@ func TestOrBoolChar(t *testing.T) {
 
 func TestAddBoolString(t *testing.T) {
 	t1 := NewBool("true")
-	t2 := NewString("Hello")
+	t2, _ := NewString("Hello")
 	actual, err := t1.Add(t2)
 	if err != nil {
 		t.Errorf("Error: %s", err)
 	}
-	expected := NewString("trueHello")
+	expected, _ := NewString("trueHello")
 	if actual != expected {
 		t.Errorf("Expected %s, got %s", expected, actual)
 	}

diff --git a/interpreter/eclaType/char_test.go b/interpreter/eclaType/char_test.go
@@ -914,25 +914,19 @@ func TestCharAppendChar(t *testing.T) {
 	t1 := Char('A')
 	t2 := Char('B')
 
-	result, err := t1.Append(t2)
-	if err != nil {
-		t.Error(err)
-	}
-	if result.GetValue() != String("AB") {
-		t.Error("Expected AB, got ", result)
+	_, err := t1.Append(t2)
+	if err == nil {
+		t.Error("Expected error")
 	}
 }
 
 func TestCharAppendString(t *testing.T) {
 	t1 := Char('A')
 	t2 := String("BC")
 
-	result, err := t1.Append(t2)
-	if err != nil {
-		t.Error(err)
-	}
-	if result.GetValue() != String("ABC") {
-		t.Error("Expected ABC, got ", result)
+	_, err := t1.Append(t2)
+	if err == nil {
+		t.Error("Expected error")
 	}
 }
 

diff --git a/interpreter/eclaType/function_test.go b/interpreter/eclaType/function_test.go
@@ -8,8 +8,8 @@ import (
 // Useless tests for code coverage purpose
 func TestGetValue(t *testing.T) {
 	f := NewFunction("test", nil, nil, nil)
-	if f.GetValue() != nil {
-		t.Errorf("Expected nil, got %v", f.GetValue())
+	if f.GetValue() == nil {
+		t.Error("Expected not nil, got nil")
 	}
 }
 
@@ -36,8 +36,8 @@ func TestGetString(t *testing.T) {
 
 func TestGetType(t *testing.T) {
 	f := NewFunction("test", nil, nil, nil)
-	if f.GetType() != "function" {
-		t.Errorf("Expected function, got %v", f.GetType())
+	if f.GetType() != "function()" {
+		t.Errorf("Expected function(), got %v", f.GetType())
 	}
 }