Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Misalignment in p2e_dv2 and p2e_dv3 Implementations with Original Paper #322

Open
tallance opened this issue Oct 10, 2024 · 0 comments

Comments

@tallance
Copy link

I've noticed a potential misalignment in the p2e_dv2 and p2e_dv3 implementations regarding what the ensemble predicts. According to the Plan2Explore paper, the ensemble should predict the image embedding, not the posterior state. The implementation in p2e_dv1 appears aligned with this:

loss -= next_obs_embedding_dist.log_prob(embedded_obs.detach()[1:]).mean()

However, in p2e_dv2 and p2e_dv3, it seems to aim to predict the next (randomized) posterior state:

loss -= next_obs_embedding_dist.log_prob(posteriors.view(sequence_length, batch_size, -1).detach()[1:]).mean()

Could this be an intentional modification, or am I missing something about how these predictions should be handled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant