Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch rowsums and colsums #21

Merged
merged 2 commits into from
Oct 14, 2021
Merged

patch rowsums and colsums #21

merged 2 commits into from
Oct 14, 2021

Conversation

mkborregaard
Copy link
Member

These two functions did not dispatch properly
Also changes the keyword for showing empty cells in the plot recipe

@coveralls
Copy link

coveralls commented Oct 11, 2021

Pull Request Test Coverage Report for Build 1327931804

  • 1 of 7 (14.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 20.161%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/PlotRecipes.jl 0 2 0.0%
src/Interface.jl 1 5 20.0%
Totals Coverage Status
Change from base Build 1292008709: -0.3%
Covered Lines: 25
Relevant Lines: 124

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #21 (913b74f) into main (3824b30) will decrease coverage by 0.33%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   20.49%   20.16%   -0.34%     
==========================================
  Files           2        2              
  Lines         122      124       +2     
==========================================
  Hits           25       25              
- Misses         97       99       +2     
Impacted Files Coverage Δ
src/PlotRecipes.jl 0.00% <0.00%> (ø)
src/Interface.jl 26.59% <20.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3824b30...913b74f. Read the comment docs.

@mkborregaard mkborregaard merged commit 669426b into main Oct 14, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1327931804

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 7 (14.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 20.161%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/PlotRecipes.jl 0 2 0.0%
src/Interface.jl 1 5 20.0%
Totals Coverage Status
Change from base Build 1292008709: -0.3%
Covered Lines: 25
Relevant Lines: 124

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 1327931804

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 7 (14.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 20.161%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/PlotRecipes.jl 0 2 0.0%
src/Interface.jl 1 5 20.0%
Totals Coverage Status
Change from base Build 1292008709: -0.3%
Covered Lines: 25
Relevant Lines: 124

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants