Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Face Area and Cell Volume Calculations #26

Open
sjordan29 opened this issue Jan 20, 2023 · 0 comments
Open

Review Face Area and Cell Volume Calculations #26

sjordan29 opened this issue Jan 20, 2023 · 0 comments

Comments

@sjordan29
Copy link
Contributor

sjordan29 commented Jan 20, 2023

In the utilities module, there are two functions (_compute_face_areas() and _compute_cell_volumes()) that are O(n^2), which could impact performance. These functions should be analyzed to see if we can achieve any gains in performance. There are also opportunities to refine these functions and/or split into smaller functions to reduce complexity and improve readability, since the nested logic within these functions makes it difficult to track, test, and debug.

Neither of these functions are used in current testing, because face areas and cell volumes are printed to the RAS output. We should develop a test HEC-RAS case that has these outputs turned off so that we can compare performance with and without these outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant