You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the utilities module, there are two functions (_compute_face_areas() and _compute_cell_volumes()) that are O(n^2), which could impact performance. These functions should be analyzed to see if we can achieve any gains in performance. There are also opportunities to refine these functions and/or split into smaller functions to reduce complexity and improve readability, since the nested logic within these functions makes it difficult to track, test, and debug.
Neither of these functions are used in current testing, because face areas and cell volumes are printed to the RAS output. We should develop a test HEC-RAS case that has these outputs turned off so that we can compare performance with and without these outputs.
The text was updated successfully, but these errors were encountered:
In the
utilities
module, there are two functions (_compute_face_areas()
and_compute_cell_volumes()
) that are O(n^2), which could impact performance. These functions should be analyzed to see if we can achieve any gains in performance. There are also opportunities to refine these functions and/or split into smaller functions to reduce complexity and improve readability, since the nested logic within these functions makes it difficult to track, test, and debug.Neither of these functions are used in current testing, because face areas and cell volumes are printed to the RAS output. We should develop a test HEC-RAS case that has these outputs turned off so that we can compare performance with and without these outputs.
The text was updated successfully, but these errors were encountered: