Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal Weighting #37

Open
sjordan29 opened this issue Sep 15, 2023 · 0 comments
Open

Temporal Weighting #37

sjordan29 opened this issue Sep 15, 2023 · 0 comments

Comments

@sjordan29
Copy link
Contributor

The transport equation includes $n + \theta$, a temporal weighting factor on the concentrations in the advection and diffusion terms. The current Clearwater-riverine model assumes that $\theta = 1$ (i.e., a first-order fully implicit Backward Euler scheme), but users should be able to specify a $\theta$ of their choice (e.g. $\theta = 0.5$ for a second-order Crank-Nicholson scheme). In general, $X^{n+\theta} = \theta X^{n+1} + (1-\theta)X^n$ (Generalized Euler scheme).

This issue can be closed when:

  1. Users can specify $\theta$
  2. A comparison has been run to determine how changing $theta$ impacts accuracy for models of various timesteps (e.g., how does a 5 second model's mass balance change when $\theta =1$ versus $\theta = 0.5$?).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant