Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] <Change Twitter Logo to X> #10240

Closed
1 task done
MaorBemdoo opened this issue Feb 21, 2024 · 2 comments
Closed
1 task done

[BUG] <Change Twitter Logo to X> #10240

MaorBemdoo opened this issue Feb 21, 2024 · 2 comments
Labels
🛠 goal: fix undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)

Comments

@MaorBemdoo
Copy link
Contributor

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

On user's profile page

Version of BioDrop (for example "v1.2.3")

v2.99.16

Description

An issuse was raised before(#9971) but it was on the qrcode modal(by the way it is resolved and closed)

But on a user's profile page all twitter logo's are not yet updated to the X logo

Steps to Reproduce

  • Go to any user's profile page e.g biodrop.io/username
  • You notice that all twitter logo's are still the former ones and not X

Screenshots

BioDrop Twitter Issue schreenshot

Do you want to work on this issue?

Yes

If "yes" to above, please explain how you would technically implement this

On https://github.com/EddieHubCommunity/BioDrop/blob/main/components/Icon.js file all users that used FaTwitter or SiTwitter on their json file will be updated to FaTwitterX before it is fetched

@MaorBemdoo MaorBemdoo added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Feb 21, 2024
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
@SaraJaoude
Copy link
Member

Thank you for raising.

Each individual user can - if they wish - update their Twitter logo from the flappy bird to the X (as this is an available icon) by editing the icon.

The logo was not updated automatically as there are some users who do not wish to make this change.

Therefore I will close this issue.

@SaraJaoude SaraJaoude closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
@EddieHubCommunity EddieHubCommunity unlocked this conversation Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 goal: fix undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)
Projects
None yet
Development

No branches or pull requests

2 participants