-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat: archiving project redirect to github profile #10386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eddiejaoude I ran this in code spaces and it redirects to main github for me meaning my github feed (presumably only if I"m already logged in). Is this the correct experience? Want to make sure I"m understanding the intention correctly here before approval
Hi @amandamartin-dev , sorry for my slow reply and thank you for testing! Every URI will redirect because we don't know if it is a username or an actual page like homepage or docs. I guess you visited the homepage of BioDrop? Which redirected you to the homepage of GitHub. We are not announcing that BioDrop will redirect as we prefer people to stop using their BioDrop URL, but we still see people using it so I was keen to not have a broken link for people and redirect to their GitHub profile (if their personal BioDrop page was visited - I was not worrying about pages like the homepage or the docs page etc) |
Ah okay - so the main page definitely redirects. I will check some other pages an profiles as well to confirm thre as well. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eddiejaoude following up on your clarification I think this PR is doing more than you want it to.
It does redirect profile pages to github profiles pages as expected, however, it also appends github to ALL biodrop subdirectories as well so for example...
Thanks @amandamartin-dev for testing again. Yes it will do all paths to GitHub paths - I know it does more than we need, but not sure how to only include profiles as we won't have the DB anymore and I just want to have a very simple redirect app I am open to any suggestions on how to make this better, but as there will be no website for people to navigate to |
Ah I see - without a database you could "whitelist" full URLs that redirect to a single page for biodrop explaining that the project has been sunset but encouraging folks to come explore other EddieHub Repos and join the community to stay up to date on whats next? wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to approved since this behavior is expected and correct
I like the idea 👍 At least we could do it for the homepage. Thanks @amandamartin-dev |
I also removed the header and the footer, to hopefully reduce confusion |
Fixes Issue
Redirect all profile requests to their GitHub profile
For example
BioDrop.io/eddiejaoude
->GitHub.com/eddiejaoude
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers