Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module keccak doesn't compile on node 12 #259

Open
vird opened this issue Nov 18, 2019 · 1 comment
Open

module keccak doesn't compile on node 12 #259

vird opened this issue Nov 18, 2019 · 1 comment

Comments

@vird
Copy link
Contributor

vird commented Nov 18, 2019

related cryptocoinjs/keccak#10
And probably ethereum tx sign should be in separate module

@swansontec
Copy link
Contributor

I have been using Node 12 too, but fortunately the keccak dependency is optional, so both NPM and Yarn are able to install edge-core-js cleanly.

There are similar problems installing edge-currency-accountbased on Node 12, but those ones are more serious and actually prevent the install from going through. We have been able to work around those using Yarn's resolutions field to force things, like "resolutions": { "scrypt.js": "0.3.0" }. A similar technique may be helpful here if this issue is preventing progress.

I agree that Ethereum signing needs to be its own module, but some dapps using our web SDK are using it, and expect to find it on the account object. Paying off this particular bit of tech debt will be tricky, but it has been on my mind for a while. It would save a lot of space on our bundle size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants