Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-JSON reply, HTTP status 503 #288

Open
vird opened this issue May 6, 2020 · 2 comments
Open

Non-JSON reply, HTTP status 503 #288

vird opened this issue May 6, 2020 · 2 comments

Comments

@vird
Copy link
Contributor

vird commented May 6, 2020

edge-core-js can crash app with unhandled rejection

Error: Non-JSON reply, HTTP status 503, /api/v2/store/ca41***/aedb***
at response.json.catch.jsonError (/usr/src/app/node_modules/edge-core-js/lib/core/storage/storage-servers.js:55:17)
at process._tickCallback (internal/process/next_tick.js:68:7)

There are no specific steps to reproduce, seems there is no retry logic here

response.json().catch(jsonError => {

Seems sync is called without proper error wrapping

@swansontec
Copy link
Contributor

Ah, I see the problem. The logic is supposed to rotate servers when anything goes wrong, but the rotation logic only applies to network errors, not errors where we can reach the server but it fails.

We need to do two things to fix this:

  1. Get that server back online.
  2. Fix the core's to do proper rotation in cases like this.

@swansontec
Copy link
Contributor

#289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants