Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling token leads to invalid app state #2335

Open
wolverineks opened this issue Jan 8, 2021 · 0 comments
Open

disabling token leads to invalid app state #2335

wolverineks opened this issue Jan 8, 2021 · 0 comments

Comments

@wolverineks
Copy link
Contributor

wolverineks commented Jan 8, 2021

A disabled token remains selected for use on the send / request screens

Steps to reproduce:

  1. select wallet / token
  2. disable token

Expected result:
select parent currencyCode?
select no wallet?

Actual result:
token still selected

Possible solution(s):

  1. convert EdgeCurrencyWallet#getEnabledTokens to a watchable property like EdgeCurrencyWallet#enabledTokens when selected token for selected wallet is disabled, update app state to reflect
  2. remove token property from EdgeCurrencyWallet#balances when disabling a token
  3. limit selected wallet / token state to the send and request screens, remove navigation to those screens from side menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant