-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kingtech (and Jetcat) Telemetry Sensors from Spektrum Rx #5576
Comments
COPIED from the previous conversation on an older issue:
Options 1,2 will allow you to log the value into telemetry logs... I see in the Google Drive document that there is already an OpenTX telemetry page.. will research that.. could be a quick way to start. |
Thank you so much! |
@crwardlaw Copy the VSpeak_ECU folder into your WIDGET folder: Then on the telemety page, create a new page (full screen, only 1 big cell) and add the VSpeak widget.. and select the ECU (5=JetCat, 6=KingTech). The data comes from telemetry values: |
Here is the firmware for Radiomaster TX16S, where status comes as sensor Tmp2. Have no way to test it, so let me know if it works, and will check in the code changes to be added to a future EdgeTX release. |
That's amazing - thank you for putting this test together so quick! I'll be back with the jet this weekend so will try it out and bring feedback on Monday at the latest. Did you have to take in consideration the two status enums that kingtech uses where you refer to one when the other is a specific value? I believe that's how it's meant to work. |
I only ported the LUA that they provided, and change the firmware to send the status on sensor Tmp2… so is the same logic that the did provide on their original lua.On Oct 8, 2024, at 3:36 PM, crwardlaw ***@***.***> wrote:
That's amazing - thank you for putting this test together so quick! I'll be back with the jet this weekend so will try it out and bring feedback on Monday at the latest.
Did you have to take in consideration the two status enums that kingtech uses where you refer to one when the other is a specific value? I believe that's how it's meant to work.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
Their LUA script is for use with their proprietry VSpeak telemetry unit which I think may pass the status data differently from the official kingtech and jetcat units, I'll give it a go this weekend and see how it goes but I think the following will also need taken into consideration:
In summary, depending on which variable in the struct in the spektrum .h below, is now coming in as Tmp2, I may get one of the status infos coming through https://github.com/SpektrumRC/SpektrumDocumentation/blob/2a8a5f9d6f85eff0d2458b9ac2b05e9dcf7ddcab/Telemetry/spektrumTelemetrySensors.h#L607 I think EGT will be coming in as Tmp1, therefore, if Tmp2 is coming in as the next variable in the struct, I reckon I will get the offCondition enum coming through to the WIDGET. |
I see, i was thinking that you have the VSpeak Translator. Lets see what telemetry sensor values you get from your ECU. If the sesors are not OK, I have a small LUA script to capture the RAW data comming from Spektrum telemetry data. we can try that after the first attempt. |
The kingtech telemetry unit which I have can be found here https://kingtechturbine.lu/KingTech-T-Modul-5-in-1-Telemetry_1 I think the recording LUA script would be useful to see both the status and offCondition |
Did a bit more work on both the LUA and Firmware. Sensors: |
1. Added Processing for Jetcat ECU Status and OffStatus 2. Fix a small problem on decoding 32bits BCD data.. that function was not used before
So I have good news and some not so suprising news - firstly thanks for your efforts so far - I can't believe how well this has went!
Thanks again, Chris |
Hi Chris, I modified to LUA to add ECU type 26, that will be Kingtech with the Kingtech telemetry module. The name shows as "Kingtech KT Tel". New Widget attached below, you can edit main.lua with your favorite editor. Negatives are the OffStatus, and Positives are the Status. But looks like we are on the right path. |
Firmware 2.10.5 was released, no more changes compared to the branch i had, so seems like the Firmware that i gave you is safe. |
I tried the widget and telemetry again over the weekend and I am unfortunately stumped at the order of the enum texts that are required. As there is no clear mapping between the Jetcat status enum : Kingtech status enum : what a spektrum Tx shows for the Jetcat enum : the Kingtech ECU screen status display : vspeak's enum, it is making it difficult to work out what the correct enum should be for the vspeak widget. However, I plan on running the turbine next weekend and that will let me match up more of the status enums between the Kingtech ECU screen and the vspeak widget which will hopefully guide me to get more of them right. I'm also going to get in touch with Kingtech again to see if they can assist by providing the enum that the Kingtech screen uses as that is really what I need. Anything else you are looking for at the moment? |
Not much that i can do on my side.. the only thing that i was looking is at the Jetti Script. Looking at the status messages on Digitech and vspeak converters for Kingtech. Digitech all positive, and vspeak has negative ones and positive ones. On the spektrum Radio, it it was made for Jetcat, it will be showing you probably the wrong status message. Looked at a few of the configurations of the Jetti Widget: The statuses for VSpeak are more richer than the digitech ones.. |
Hi! So i have managed to confirm a few more of the status enum values this weekend by running the jet. Unfortunately I think a few may be missing due to the jetcat enum which I believe it is based on - such as no "cooling" value. Thought I was able to see a number of values with similar descriptions which has given me confidence that I am on the right track. With this further testing I have discovered that I am unable to check whether the offCondition is working, and in fact, it may not be.
Thanks, Chris |
Sorry for the delay, did not see your response.. Populated the Status on 'TMP4' and offStatus in 'TMP5'. |
Is there an existing issue for this feature request?
Is your feature request related to a problem?
When using a Spektrum Rx, Kingtech turbine telemetry kiddy-backs on the Spektrum built-in Jetcat Telemetry structs. However, EdgeTx does not import the STATUS field which is based upon enums. Kingtech and Jetcat use different enums. My Radio master TX16s Max with Spectrum Rx detects the majority of the Jetcat/Kingtech Telemetry data but not status. I have linked useful documents in the additional context section. N.B.: the status enum for Kingtech seems to use two enums depending on whether the first enum is a specific value.
The status enums may also be applicable to other Rx protocols, this may not only benefit Spektrum users.
Describe the solution you'd like
Preferably option 2 below so that all telemetry and sensor information is held on the one page on the UI.
Describe alternatives you've considered
Additional context
Spektrum's X-Bus file showing Jetcat enum and Jetcat struct: https://github.com/SpektrumRC/SpektrumDocumentation/blob/2a8a5f9d6f85eff0d2458b9ac2b05e9dcf7ddcab/Telemetry/spektrumTelemetrySensors.h#L739
EdgeTx Spektrum telemetry file showing a TODO for adding status telemetry:
edgetx/radio/src/telemetry/spektrum.cpp
Line 193 in 149e1a2
Document showing the differences between enums for Jetcat and Kingtech - page 41 section 2.9.4: https://drive.google.com/file/d/1TfaMCA3zpDcdGQMnRq5MnjJexTBp-VZD/view
The text was updated successfully, but these errors were encountered: