Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with EM handling in main #5607

Open
1 task done
3djc opened this issue Oct 12, 2024 · 7 comments · May be fixed by #5686
Open
1 task done

Issue with EM handling in main #5607

3djc opened this issue Oct 12, 2024 · 7 comments · May be fixed by #5686
Labels
bug/regression ↩️ A new version of EdgeTX broke something bug 🪲 Something isn't working em Emergency Mode trigger firmware General radio firmware issue, not colorlcd or B&W specific

Comments

@3djc
Copy link
Collaborator

3djc commented Oct 12, 2024

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

After EM happens, SD is mounted, sound is available, I guess LUA possibly too

Expected Behavior

In EM reboot mode, SD must stay unmounted, to prevent entering a EM loop sequence

Steps To Reproduce

Trigger EM on a debug build

Version

Nightly (Please give date/commit below)

Transmitter

Other (Please specify below)

Operating System (OS)

No response

OS Version

No response

Anything else?

Found this testing future hardware, but the issue is not hardware related. I have seen it in BW, I have not checked colorlcd (nor have I tested 2.10). I will not be able to work on this for at least 5 or 6 weeks

@3djc 3djc added bug 🪲 Something isn't working em Emergency Mode trigger bug/regression ↩️ A new version of EdgeTX broke something firmware General radio firmware issue, not colorlcd or B&W specific labels Oct 12, 2024
@philmoz
Copy link
Collaborator

philmoz commented Oct 12, 2024

Are you building without RTC_BACKUP_RAM set?

Looking at the code the behaviour you describe would only happen if RTC_BACKUP_RAM is not defined.

@3djc
Copy link
Collaborator Author

3djc commented Oct 12, 2024

Is it not defaulted for all radio ? I'm at least not excluding it

@philmoz
Copy link
Collaborator

philmoz commented Oct 12, 2024

It should be; but looking at the code this is the only reason I can see why the SD would be mounted.

@3djc
Copy link
Collaborator Author

3djc commented Oct 15, 2024

Tested Boxer, same issue, so my guess it affect all BW radios

@philmoz
Copy link
Collaborator

philmoz commented Oct 15, 2024

It would appear the RTC_BACKUP_RAM is not defined for B&W radios. It looks the same in OpenTX.

Since there is no backup what else can EM do; but load the model settings from the SD card?

@3djc
Copy link
Collaborator Author

3djc commented Oct 15, 2024

Yeah but OTX had models in eeprom. The issue is you can run into boot loops if the source of the EM is sd card related. Need to assess what we can do, maybe limit sd access to bare minimum.

Also, many new BW are using F4, need to check if the rtc register are available on those

@3djc
Copy link
Collaborator Author

3djc commented Oct 16, 2024

I have successfully run RTC_BACKUP_RAM based EM on a RM Boxer, will do a PR for BW F4 when I'm physically capable

@3djc 3djc linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something bug 🪲 Something isn't working em Emergency Mode trigger firmware General radio firmware issue, not colorlcd or B&W specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants